From: Andi Kleen <andi@firstfloor.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "Luck, Tony" <tony.luck@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@kernel.org>,
Borislav Petkov <bp@alien8.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Request for help: what did I do wrong with idtentry?
Date: Sat, 15 Nov 2014 19:28:06 +0100 [thread overview]
Message-ID: <20141115182806.GZ12538@two.firstfloor.org> (raw)
In-Reply-To: <CALCETrVLwzhQVMbu2c=NCzAfEBWa8=SOpfu5gPoxpuTBcNngRA@mail.gmail.com>
> I'm not
> completely thrilled with what it does to double_fault, though. If we
> somehow get a double fault caused by an interrupt hitting userspace
> with a bad kernel_stack, then we'll end up page faulting in the
> double_fault prologue. I'm not convinced that this is worth worrying
> about. It would be easy enough to fix, though, even if it would
> further uglify the code.
If you're "cleaning up" good and working code the functionality should
be the same as before. The old code handled this situation fine.
So your new code should handle this too.
In general yes handling all the corner cases makes code ugly.
That is how the existing code got how it became.
-Andi
next prev parent reply other threads:[~2014-11-15 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 22:25 Request for help: what did I do wrong with idtentry? Andy Lutomirski
2014-11-15 0:52 ` Luck, Tony
2014-11-15 1:21 ` Andy Lutomirski
2014-11-15 18:28 ` Andi Kleen [this message]
2014-11-15 18:45 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141115182806.GZ12538@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.