From: Konrad Zapalowicz <bergo.torino@gmail.com>
To: Christian Resell <christian.resell@gmail.com>
Cc: m.chehab@samsung.com, devel@driverdev.osuosl.org,
askb23@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, yongjun_wei@trendmicro.com.cn,
hans.verkuil@cisco.com, pavel@ucw.cz, pali.rohar@gmail.com,
fengguang.wu@intel.com, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: media: bcm2048: fix coding style error
Date: Sat, 15 Nov 2014 21:12:18 +0100 [thread overview]
Message-ID: <20141115201218.GC8088@t400> (raw)
In-Reply-To: <20141115194337.GF15904@Kosekroken.jensen.com>
On 11/15, Christian Resell wrote:
> Simple style fix (checkpatch.pl: "space prohibited before that ','").
> For the eudyptula challenge (http://eudyptula-challenge.org/).
Nice, however we do not need the information about the 'eudyptula
challenge' in the commit message.
If you want to include extra information please do it after the '---'
line (just below the signed-off). You will find more details in the
SubmittingPatches (chapter 15) of the kernel documentation.
Thanks,
Konrad
> Signed-off-by: Christian F. Resell <christian.resell@gmail.com>
> ---
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 2bba370..bdc6854 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2707,7 +2707,7 @@ static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client)
> * bcm2048_i2c_driver - i2c driver interface
> */
> static const struct i2c_device_id bcm2048_id[] = {
> - { "bcm2048" , 0 },
> + { "bcm2048", 0 },
> { },
> };
> MODULE_DEVICE_TABLE(i2c, bcm2048_id);
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2014-11-15 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 19:43 [PATCH] staging: media: bcm2048: fix coding style error Christian Resell
2014-11-15 20:12 ` Konrad Zapalowicz [this message]
2014-11-15 20:59 ` Pavel Machek
2014-11-15 21:25 ` Greg KH
2014-11-16 10:20 ` Mauro Carvalho Chehab
2014-11-15 21:32 ` Konrad Zapalowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141115201218.GC8088@t400 \
--to=bergo.torino@gmail.com \
--cc=askb23@gmail.com \
--cc=christian.resell@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.