All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Razya Ladelsky <RAZYA@il.ibm.com>
Cc: kvm@vger.kernel.org, Joel Nider <JOELN@il.ibm.com>,
	Yossi Kuperman1 <YOSSIKU@il.ibm.com>,
	Alex Glikson <GLIKSON@il.ibm.com>,
	Eyal Moscovici <EYALMO@il.ibm.com>
Subject: Re: Benchmarking for vhost polling patch
Date: Sun, 16 Nov 2014 16:56:28 +0200	[thread overview]
Message-ID: <20141116145628.GA12033@redhat.com> (raw)
In-Reply-To: <OFC28F7233.ADFB817C-ONC2257D92.004127D3-C2257D92.0042B9F7@il.ibm.com>

On Sun, Nov 16, 2014 at 02:08:49PM +0200, Razya Ladelsky wrote:
> Razya Ladelsky/Haifa/IBM@IBMIL wrote on 29/10/2014 02:38:31 PM:
> 
> > From: Razya Ladelsky/Haifa/IBM@IBMIL
> > To: mst@redhat.com
> > Cc: Razya Ladelsky/Haifa/IBM@IBMIL, Alex Glikson/Haifa/IBM@IBMIL, 
> > Eran Raichstein/Haifa/IBM@IBMIL, Yossi Kuperman1/Haifa/IBM@IBMIL, 
> > Joel Nider/Haifa/IBM@IBMIL, abel.gordon@gmail.com, kvm@vger.kernel.org
> > Date: 29/10/2014 02:38 PM
> > Subject: Benchmarking for vhost polling patch
> > 
> > Hi Michael,
> > 
> > Following the polling patch thread: http://marc.info/?
> > l=kvm&m=140853271510179&w=2, 
> > I changed poll_stop_idle to be counted in micro seconds, and carried out 
> 
> > experiments using varying sizes of this value. 
> > 
> > If it makes sense to you, I will continue with the other changes 
> > requested for 
> > the patch.
> > 
> > Thank you,
> > Razya
> > 
> > 
> 
> Dear Michael,
> I'm still interested in hearing your opinion about these numbers 
> http://marc.info/?l=kvm&m=141458631532669&w=2, 
> and whether it is worthwhile to continue with the polling patch.
> Thank you,
> Razya 
> 
> 
> > 
> > 

Hi Razya,
On the netperf benchmark, it looks like polling=10 gives a modest but
measureable gain.  So from that perspective it might be worth it if it's
not too much code, though we'll need to spend more time checking the
macro effect - we barely moved the needle on the macro benchmark and
that is suspicious.
Is there a chance you are actually trading latency for throughput?
do you observe any effect on latency?
How about trying some other benchmark, e.g. NFS?


Also, I am wondering:

since vhost thread is polling in kernel anyway, shouldn't
we try and poll the host NIC?
that would likely reduce at least the latency significantly,
won't it?


-- 
MST

  reply	other threads:[~2014-11-16 14:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-16 12:08 Benchmarking for vhost polling patch Razya Ladelsky
2014-11-16 14:56 ` Michael S. Tsirkin [this message]
     [not found] <1416919320-razya@il.ibm.com>
2014-11-25 12:42 ` Razya Ladelsky
     [not found] <1414586281-razya@il.ibm.com>
2014-10-29 12:38 ` Razya Ladelsky
2014-10-30 11:30   ` Zhang Haoyu
2014-10-30 12:11     ` Razya Ladelsky
2014-10-31  2:21       ` Zhang Haoyu
2014-11-09 12:19   ` Razya Ladelsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141116145628.GA12033@redhat.com \
    --to=mst@redhat.com \
    --cc=EYALMO@il.ibm.com \
    --cc=GLIKSON@il.ibm.com \
    --cc=JOELN@il.ibm.com \
    --cc=RAZYA@il.ibm.com \
    --cc=YOSSIKU@il.ibm.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.