From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH 1/4] xen: Correction to module@1 (dom0
	kernel) DT node.
Date: Sun, 16 Nov 2014 12:26:06 -0800
Message-ID: <20141116202606.GD9960@lvm>
References: <CAMJs5B-aJb=CzatgdXT2s6rM7aYjvTSwUg5PzSOUeDy=o=bmyA@mail.gmail.com>
	<1415628601-31075-1-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1415628601-31075-1-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On Mon, Nov 10, 2014 at 02:09:58PM +0000, Ian Campbell wrote:
> - Include bootargs (kernel command line) property.

Why?

The logic I was going for was to reduce duplicate code/entries in the
DT, and if I read docs/misc/arm/device-tree/booting.txt, the fact that
we have xen,xen-bootargs but no xen,dom0-bootargs then bootargs added
further down in Makefile.am will be used.

Is this not correct or not preferred for some reason?

-Christoffer

> - Update reg property to match #address-cells and #size-cells in the DTB (both
>   2).
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
>  Makefile.am |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 9b6c7e3..ed5acbb 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -69,8 +69,9 @@ XEN_OFFSET	:= 0xA00000
>  DOM0_OFFSET	:= $(shell echo $$(($(PHYS_OFFSET) + $(KERNEL_OFFSET))))
>  XEN_BOOTARGS	:= xen,xen-bootargs = \"$(BOOTARGS)\";			\
>  		   module@1 {						\
> +			bootargs = \"$(CMDLINE)\";			\
>  			compatible = \"xen,linux-zimage\", \"xen,multiboot-module\"; \
> -			reg = <$(DOM0_OFFSET) 0x800000>;		\
> +			reg = <0 $(DOM0_OFFSET) 0 0x800000>;		\
>  		   };
>  endif
>  
> -- 
> 1.7.10.4
>