All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] docs/manual: document the new variable FOO_UPSTREAM_SOURCE
Date: Sun, 16 Nov 2014 23:13:55 +0100	[thread overview]
Message-ID: <20141116221355.GF10840@free.fr> (raw)
In-Reply-To: <20141116061946.GA2449@sapphire.tkos.co.il>

Baruch, All,

On 2014-11-16 08:19 +0200, Baruch Siach spake thusly:
> On Sat, Nov 15, 2014 at 05:19:29PM +0100, Yann E. MORIN wrote:
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> > Cc: Samuel Martin <s.martin49@gmail.com>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Cc: Peter Korsgaard <jacmet@uclibc.org>
> > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> > Cc: Arnout Vandecappelle <arnout@mind.be>
> > ---
> >  docs/manual/adding-packages-generic.txt | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt
> > index 67a7453..5295681 100644
> > --- a/docs/manual/adding-packages-generic.txt
> > +++ b/docs/manual/adding-packages-generic.txt
> > @@ -211,6 +211,17 @@ information is (assuming the package name is +libfoo+) :
> >    +libfoo-$(LIBFOO_VERSION).tar.gz+. +
> >    Example: +LIBFOO_SOURCE = foobar-$(LIBFOO_VERSION).tar.bz2+
> >  
> > +* +LIBFOO_UPSTREAM_SOURCE+ may contain the name of the tarball as
> > +  known by upstream. If +HOST_LIBFOO_UPSTREAM_SOURCE+ is not specified,
> > +  it defaults to +LIBFOO_UPSTREAM_SOURCE+. If none is specified, then
> > +  the value is assumed to be the same as +LIBFOO_SOURCE+.
> > +
> > +.Note
> > ++LIBFOO_SOURCE+ is the filename we want to save the tarball as, while
> > ++LIBFOO_UPSTREAM_SOURCE+ is the name by which upstream names that
> > +tarball. The two are usually the same, except in very rare cases, so you
> > +normally should not have to set +LIBFOO_UPSTREAM_SOURCE+.
> 
> I think it is worth clarifying which name the .hash file should refer in this 
> case. I guess this is LIBFOO_SOURCE, isn't it?.

Nice catch, indeed! :-)

Yes, this should be referencing the local tarball filename. I'll add
this to the manual.

Thank! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-11-16 22:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-15 16:19 [Buildroot] [PATCH 0/4] pkg-infra: differentiate remote and local tarball filenames (branch yem/download) Yann E. MORIN
2014-11-15 16:19 ` [Buildroot] [PATCH 1/4] pkg-infra: always specify the local tarball name when calling DOWNLOAD Yann E. MORIN
2014-11-18 20:41   ` Arnout Vandecappelle
2014-11-23 17:02     ` Yann E. MORIN
2014-11-15 16:19 ` [Buildroot] [PATCH 2/4] pkg-infra: squash DOWNLOAD_INNER into DOWNLOAD Yann E. MORIN
2014-11-15 16:19 ` [Buildroot] [PATCH 3/4] pkg-infra: differentiate remote tarball name from local filename Yann E. MORIN
2014-11-18 20:54   ` Arnout Vandecappelle
2014-11-23 17:06     ` Yann E. MORIN
2014-11-23 17:18       ` Yann E. MORIN
2014-11-15 16:19 ` [Buildroot] [PATCH 4/4] docs/manual: document the new variable FOO_UPSTREAM_SOURCE Yann E. MORIN
2014-11-16  6:19   ` Baruch Siach
2014-11-16 22:13     ` Yann E. MORIN [this message]
2014-11-16 11:22 ` [Buildroot] [PATCH 0/4] pkg-infra: differentiate remote and local tarball filenames (branch yem/download) Thomas Petazzoni
2014-11-18 20:38   ` Arnout Vandecappelle
2014-11-18 21:03     ` Thomas Petazzoni
2014-11-18 21:50       ` Arnout Vandecappelle
2014-11-23 17:25       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141116221355.GF10840@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.