From: Greg KH <gregkh@linuxfoundation.org>
To: Seth Jennings <sjenning@redhat.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Jiri Kosina <jkosina@suse.cz>, Vojtech Pavlik <vojtech@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Petr Mladek <pmladek@suse.cz>, Miroslav Benes <mbenes@suse.cz>,
Christoph Hellwig <hch@infradead.org>,
Andy Lutomirski <luto@amacapital.net>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
live-patching@vger.kernel.org, x86@kernel.org, kpatch@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 2/3] kernel: add support for live patching
Date: Mon, 17 Nov 2014 10:45:58 -0800 [thread overview]
Message-ID: <20141117184558.GA13995@kroah.com> (raw)
In-Reply-To: <1416187764-3341-3-git-send-email-sjenning@redhat.com>
On Sun, Nov 16, 2014 at 07:29:23PM -0600, Seth Jennings wrote:
> +#ifdef CONFIG_X86_32
> +int lpc_write_module_reloc(struct module *mod, unsigned long type,
> + unsigned long loc, unsigned long value)
> +{
> + pr_err("Live patching not supported on 32-bit x86\n");
> + return -ENOSYS;
> +}
Why not just prevent the code from being built on x86_32 instead of
putting this in the file?
thanks,
greg k-h
next prev parent reply other threads:[~2014-11-17 18:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 1:29 [PATCHv2 0/3] Kernel Live Patching Seth Jennings
2014-11-17 1:29 ` [PATCHv2 1/3] kernel: add TAINT_LIVEPATCH Seth Jennings
2014-11-17 1:29 ` [PATCHv2 2/3] kernel: add support for live patching Seth Jennings
2014-11-17 18:45 ` Greg KH [this message]
2014-11-17 19:13 ` Seth Jennings
2014-11-18 14:11 ` Miroslav Benes
2014-11-18 14:26 ` Seth Jennings
2014-11-18 14:45 ` Miroslav Benes
2014-11-19 20:34 ` Seth Jennings
2014-11-20 13:22 ` Miroslav Benes
2014-11-19 15:27 ` Miroslav Benes
2014-11-19 16:05 ` Seth Jennings
2014-11-20 13:10 ` Miroslav Benes
2014-11-20 17:35 ` Josh Poimboeuf
2014-11-20 19:56 ` Seth Jennings
2014-11-21 14:41 ` Miroslav Benes
2014-11-21 14:38 ` Miroslav Benes
2014-11-20 15:19 ` Josh Poimboeuf
2014-11-20 16:48 ` Seth Jennings
2014-11-17 1:29 ` [PATCHv2 3/3] kernel: add sysfs documentation " Seth Jennings
2014-11-17 18:50 ` Greg KH
2014-11-17 5:33 ` [PATCHv2 0/3] Kernel Live Patching Masami Hiramatsu
2014-11-17 13:16 ` Steven Rostedt
2014-11-17 14:54 ` Seth Jennings
2014-11-18 14:23 ` Jiri Slaby
2014-11-18 14:42 ` Seth Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117184558.GA13995@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=kpatch@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.