From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 5/5] package: linux-fusion: use install instead of cp
Date: Mon, 17 Nov 2014 22:49:27 +0100 [thread overview]
Message-ID: <20141117214927.GJ12473@free.fr> (raw)
In-Reply-To: <1416244750-24256-6-git-send-email-guido@vanguardiasur.com.ar>
Guido, All,
On 2014-11-17 14:19 -0300, Guido Mart?nez spake thusly:
> in order to not depend on the previous permissions of the file
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
But see a comment below...
> ---
> package/linux-fusion/linux-fusion.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/linux-fusion/linux-fusion.mk b/package/linux-fusion/linux-fusion.mk
> index c5e7976..001388c 100644
> --- a/package/linux-fusion/linux-fusion.mk
> +++ b/package/linux-fusion/linux-fusion.mk
> @@ -36,8 +36,8 @@ define LINUX_FUSION_INSTALL_TARGET_CMDS
> $(LINUX_FUSION_MAKE_OPTS) \
> INSTALL_MOD_PATH=$(TARGET_DIR) \
> -C $(@D) install
> - mkdir -p $(LINUX_FUSION_ETC_DIR)
> - cp -dpf package/linux-fusion/40-fusion.rules $(LINUX_FUSION_ETC_DIR)
> + $(INSTALL) -D -m 644 package/linux-fusion/40-fusion.rules \
> + $(LINUX_FUSION_ETC_DIR)/40-fusion.rules
Here, you used a correct construct when calling isntall. ;-)
Regards,
Yann E. MORIN.
> endef
>
> $(eval $(generic-package))
> --
> 2.1.3
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-11-17 21:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 17:19 [Buildroot] [PATCH v3 0/5] Target permissions Guido Martínez
2014-11-17 17:19 ` [Buildroot] [PATCH v3 1/5] Makefile: don't depend on the umask Guido Martínez
2014-11-17 21:11 ` Arnout Vandecappelle
2014-11-18 17:01 ` Guido Martínez
2014-11-18 19:22 ` Arnout Vandecappelle
2014-11-17 21:36 ` Yann E. MORIN
2014-11-17 21:41 ` Arnout Vandecappelle
2014-11-17 21:48 ` Yann E. MORIN
2014-11-17 17:19 ` [Buildroot] [PATCH v3 2/5] Makefile: don't depend on current skeleton/overlay permissions Guido Martínez
2014-11-17 21:39 ` Yann E. MORIN
2014-11-17 17:19 ` [Buildroot] [PATCH v3 3/5] pkg-generic.mk: don't depend on external package permissions Guido Martínez
2014-11-17 21:41 ` Yann E. MORIN
2014-11-18 17:02 ` Guido Martínez
2014-11-17 17:19 ` [Buildroot] [PATCH v3 4/5] package: matchbox-keyboard: use install instead of cp Guido Martínez
2014-11-17 21:44 ` Yann E. MORIN
2014-11-18 17:06 ` Guido Martínez
2014-11-17 17:19 ` [Buildroot] [PATCH v3 5/5] package: linux-fusion: " Guido Martínez
2014-11-17 21:49 ` Yann E. MORIN [this message]
2014-11-17 22:06 ` Arnout Vandecappelle
2014-11-18 17:17 ` Guido Martínez
2014-11-18 19:23 ` Arnout Vandecappelle
2014-11-18 19:40 ` Guido Martínez
2014-11-18 20:58 ` Arnout Vandecappelle
2014-11-18 22:59 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117214927.GJ12473@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.