From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Mon, 17 Nov 2014 23:31:58 +0000 Subject: [PATCH 4/7] dt-bindings: Add document for MT6397 MFD In-Reply-To: <1416210027-5562-5-git-send-email-flora.fu@mediatek.com> References: <1416210027-5562-1-git-send-email-flora.fu@mediatek.com> <1416210027-5562-5-git-send-email-flora.fu@mediatek.com> Message-ID: <20141117233158.GD22111@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Nov 17, 2014 at 03:40:24PM +0800, Flora Fu wrote: > + pmic { > + compatible = "mediatek,mt6397"; > + } This looks like it's missing a closing brace and is just generally weird (having a subnode like this). > +- regulators : The regulators of mt6397 > + regulators { > + regulator constratints. > + refer Documentation/devicetree/bindings/regulator/regulator.txt > + }; You need to define the set of valid regulator names and how that maps onto the physical device, look at other regulator binding documents for examples. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 4/7] dt-bindings: Add document for MT6397 MFD Date: Mon, 17 Nov 2014 23:31:58 +0000 Message-ID: <20141117233158.GD22111@sirena.org.uk> References: <1416210027-5562-1-git-send-email-flora.fu@mediatek.com> <1416210027-5562-5-git-send-email-flora.fu@mediatek.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zbGR4y+acU1DwHSi" Return-path: Content-Disposition: inline In-Reply-To: <1416210027-5562-5-git-send-email-flora.fu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Flora Fu Cc: Rob Herring , Mark Rutland , Matthias Brugger , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , Samuel Ortiz , Lee Jones , Liam Girdwood , Grant Likely , "Joe.C" , Catalin Marinas , Vladimir Murzin , Ashwin Chaugule , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Sascha Hauer , Eddie Huang , Dongdong Cheng List-Id: devicetree@vger.kernel.org --zbGR4y+acU1DwHSi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 17, 2014 at 03:40:24PM +0800, Flora Fu wrote: > + pmic { > + compatible = "mediatek,mt6397"; > + } This looks like it's missing a closing brace and is just generally weird (having a subnode like this). > +- regulators : The regulators of mt6397 > + regulators { > + regulator constratints. > + refer Documentation/devicetree/bindings/regulator/regulator.txt > + }; You need to define the set of valid regulator names and how that maps onto the physical device, look at other regulator binding documents for examples. --zbGR4y+acU1DwHSi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUaoVtAAoJECTWi3JdVIfQ8kgH/izzeNVKV3wqoRUD+YlTtGJv axaLPulZTC3jXb8nQ9F+zo4oRlpvPayFWViGTsKmDapYOw6AiCaIXUq3MG1QJc9g 9VE21l99zXeYVmVoTjUlYIaUBbHqHi/9OVutgLJE2DeCyTPv+HMCBdFmE4jM889T E3buJd7WMIruoH9IXWZO2dGS8KvpyCWANPL7SzulSwaOgQ2mKb8rqCkFEC+NurgX usjyGaC5Wv4eqHhX58O9taFL8lqOxfUQfkLuX6sxE1K9Z3vqEpyuaJ8hP2C92f+Y +yGJdmf8tmUBEU75CoxipeUKPsViJsKdW/DVBznH9/JlTu7/L5Xo9LkbkPkwQ1o= =BJY6 -----END PGP SIGNATURE----- --zbGR4y+acU1DwHSi-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752433AbaKQXco (ORCPT ); Mon, 17 Nov 2014 18:32:44 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45528 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbaKQXcm (ORCPT ); Mon, 17 Nov 2014 18:32:42 -0500 Date: Mon, 17 Nov 2014 23:31:58 +0000 From: Mark Brown To: Flora Fu Cc: Rob Herring , Mark Rutland , Matthias Brugger , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , Samuel Ortiz , Lee Jones , Liam Girdwood , Grant Likely , "Joe.C" , Catalin Marinas , Vladimir Murzin , Ashwin Chaugule , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, Sascha Hauer , Eddie Huang , Dongdong Cheng Message-ID: <20141117233158.GD22111@sirena.org.uk> References: <1416210027-5562-1-git-send-email-flora.fu@mediatek.com> <1416210027-5562-5-git-send-email-flora.fu@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zbGR4y+acU1DwHSi" Content-Disposition: inline In-Reply-To: <1416210027-5562-5-git-send-email-flora.fu@mediatek.com> X-Cookie: You look tired. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 149.254.182.38 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/7] dt-bindings: Add document for MT6397 MFD X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zbGR4y+acU1DwHSi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 17, 2014 at 03:40:24PM +0800, Flora Fu wrote: > + pmic { > + compatible = "mediatek,mt6397"; > + } This looks like it's missing a closing brace and is just generally weird (having a subnode like this). > +- regulators : The regulators of mt6397 > + regulators { > + regulator constratints. > + refer Documentation/devicetree/bindings/regulator/regulator.txt > + }; You need to define the set of valid regulator names and how that maps onto the physical device, look at other regulator binding documents for examples. --zbGR4y+acU1DwHSi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUaoVtAAoJECTWi3JdVIfQ8kgH/izzeNVKV3wqoRUD+YlTtGJv axaLPulZTC3jXb8nQ9F+zo4oRlpvPayFWViGTsKmDapYOw6AiCaIXUq3MG1QJc9g 9VE21l99zXeYVmVoTjUlYIaUBbHqHi/9OVutgLJE2DeCyTPv+HMCBdFmE4jM889T E3buJd7WMIruoH9IXWZO2dGS8KvpyCWANPL7SzulSwaOgQ2mKb8rqCkFEC+NurgX usjyGaC5Wv4eqHhX58O9taFL8lqOxfUQfkLuX6sxE1K9Z3vqEpyuaJ8hP2C92f+Y +yGJdmf8tmUBEU75CoxipeUKPsViJsKdW/DVBznH9/JlTu7/L5Xo9LkbkPkwQ1o= =BJY6 -----END PGP SIGNATURE----- --zbGR4y+acU1DwHSi--