From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753787AbaKRCBt (ORCPT ); Mon, 17 Nov 2014 21:01:49 -0500 Received: from one.firstfloor.org ([193.170.194.197]:49323 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752749AbaKRCBr (ORCPT ); Mon, 17 Nov 2014 21:01:47 -0500 Date: Tue, 18 Nov 2014 03:01:45 +0100 From: Andi Kleen To: Namhyung Kim Cc: Andi Kleen , jolsa@redhat.com, linux-kernel@vger.kernel.org, acme@kernel.org, Andi Kleen Subject: Re: [PATCH 2/8] perf, tools: Add --branch-history option to report Message-ID: <20141118020145.GF12538@two.firstfloor.org> References: <1411774636-6870-1-git-send-email-andi@firstfloor.org> <1411774636-6870-3-git-send-email-andi@firstfloor.org> <87mw8ogaj8.fsf@sejong.aot.lge.com> <20141112000505.GM12538@two.firstfloor.org> <87389itk0y.fsf@sejong.aot.lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87389itk0y.fsf@sejong.aot.lge.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 17, 2014 at 03:31:57PM +0900, Namhyung Kim wrote: > On Wed, 12 Nov 2014 01:05:05 +0100, Andi Kleen wrote: > >> And please also add a new CCKEY_SRCLINE if you print srcline with the > >> callchains so that users can give "-g srcline" if they want (regardless > >> of the branch history feature). > > > > That would be largely identical to CCKEY_ADDRESS > > except for the case of two calls to the same function from > > the same line. Probably not worth adding? > > For sorting, yes, it'd be almost identical. But what I'm saying is for > printing - IOW print callchain entries with symbol and srcline (for > normal perf report too). But I thought the key is only for sorting? I already added an option to print the src line and it should work for normal perf report. -Andi