[U-Boot] [PATCH 0/2] mxssb: trivial fixes

[U-Boot] [PATCH 0/2] mxssb: trivial fixes

[Marc Kleine-Budde]

Hey,

this is a trivial patch series for the mxssb tool. Please review and apply.

regards,
Marc

[U-Boot] [PATCH 1/2] mxssb: Makefile: build with optimisation (-O2) by default

[Marc Kleine-Budde]

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index a8dbea3a861b..af3deb920785 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,4 @@
-CFLAGS=`pkg-config --cflags libcrypto` -Wall -Wextra
+CFLAGS=`pkg-config --cflags libcrypto` -Wall -Wextra -O2
 LDFLAGS=`pkg-config --libs libcrypto`
 
 mxssb:	mxssb.c
-- 
2.1.3

[U-Boot] [PATCH 2/2] mxssb: fix uninitialized variables warnings

[Marc Kleine-Budde]

These warning are generated by: gcc version 4.9.1 (Debian 4.9.1-19)

mxssb.c: In function ?main?:
mxssb.c:1580:10: warning: ?ilen? may be used uninitialized in this function [-Wmaybe-uninitialized]
    ret = sb_build_dcd_block(ictx, cmd, SB_DCD_CHK_EQ | ilen);
          ^
mxssb.c:1553:12: note: ?ilen? was declared here
   uint32_t ilen;
            ^
mxssb.c:1556:28: warning: ?rptr? may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (!tok || (strlen(tok) == 0) || (lptr && strlen(lptr) != 1)) {
                            ^
mxssb.c:1495:8: note: ?rptr? was declared here
  char *rptr;
        ^

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 mxssb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mxssb.c b/mxssb.c
index 14826e7bf84c..3a4c32cf47c9 100644
--- a/mxssb.c
+++ b/mxssb.c
@@ -1492,7 +1492,7 @@ static int sb_parse_line(struct sb_image_ctx *ictx, struct sb_cmd_list *cmd)
 {
 	char *tok;
 	char *line = cmd->cmd;
-	char *rptr;
+	char *rptr = NULL;
 	int ret;
 
 	/* Analyze the identifier on this line first. */
@@ -1550,7 +1550,7 @@ static int sb_parse_line(struct sb_image_ctx *ictx, struct sb_cmd_list *cmd)
 		}
 	} else if (ictx->in_dcd) {
 		char *lptr;
-		uint32_t ilen;
+		uint32_t ilen = 0;
 
 		tok = strtok_r(tok, ".", &lptr);
 		if (!tok || (strlen(tok) == 0) || (lptr && strlen(lptr) != 1)) {
-- 
2.1.3

[U-Boot] [PATCH 0/2] mxssb: trivial fixes

[Marek Vasut]

On Tuesday, November 18, 2014 at 10:33:44 AM, Marc Kleine-Budde wrote:
> Hey,

Hi!

> this is a trivial patch series for the mxssb tool. Please review and apply.

The mxssb tool is dead, the U-Boot has support for generating the MXS images
directly (see tools/mxsimage.[ch]). Can you please verify if your patches still 
apply to that file (they should) ? Would it be possible for you to prepare a 
patch for the mxsimage tool instead please ?

Thank you for your help!

Best regards,
Marek Vasut