diff for duplicates of <20141118153932.GA3790@redhat.com> diff --git a/a/1.txt b/N1/1.txt index e6fda5b..1f05571 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,7 +9,7 @@ On 11/18, Dan Carpenter wrote: > happy but these are normally precedence bugs so I think it's ok to put > parenthesis so it's clear the code is deliberate. -I still think that "if (!A = B)" doesn't look as a potential precedence +I still think that "if (!A == B)" doesn't look as a potential precedence bug, but I won't argue. Andrew, this fixes exit-reparent-cleanup-the-changing-of-parent.patch @@ -25,8 +25,8 @@ in -mm tree. > list_for_each_entry(p, &father->children, sibling) { > for_each_thread(p, t) { > t->real_parent = reaper; -> - BUG_ON(!t->ptrace != (t->parent = father)); -> + BUG_ON((!t->ptrace) != (t->parent = father)); +> - BUG_ON(!t->ptrace != (t->parent == father)); +> + BUG_ON((!t->ptrace) != (t->parent == father)); > if (likely(!t->ptrace)) > t->parent = t->real_parent; > if (t->pdeath_signal) diff --git a/a/content_digest b/N1/content_digest index a01066f..91fdcce 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020141118074422.GA17829@mwanda\0" "From\0Oleg Nesterov <oleg@redhat.com>\0" "Subject\0Re: [patch] exit: silence a bogus static checker warning\0" - "Date\0Tue, 18 Nov 2014 15:39:32 +0000\0" + "Date\0Tue, 18 Nov 2014 16:39:32 +0100\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Andrew Morton <akpm@linux-foundation.org>" Michal Hocko <mhocko@suse.cz> @@ -25,7 +25,7 @@ "> happy but these are normally precedence bugs so I think it's ok to put\n" "> parenthesis so it's clear the code is deliberate.\n" "\n" - "I still think that \"if (!A = B)\" doesn't look as a potential precedence\n" + "I still think that \"if (!A == B)\" doesn't look as a potential precedence\n" "bug, but I won't argue.\n" "\n" "Andrew, this fixes exit-reparent-cleanup-the-changing-of-parent.patch\n" @@ -41,10 +41,10 @@ "> \tlist_for_each_entry(p, &father->children, sibling) {\n" "> \t\tfor_each_thread(p, t) {\n" "> \t\t\tt->real_parent = reaper;\n" - "> -\t\t\tBUG_ON(!t->ptrace != (t->parent = father));\n" - "> +\t\t\tBUG_ON((!t->ptrace) != (t->parent = father));\n" + "> -\t\t\tBUG_ON(!t->ptrace != (t->parent == father));\n" + "> +\t\t\tBUG_ON((!t->ptrace) != (t->parent == father));\n" "> \t\t\tif (likely(!t->ptrace))\n" "> \t\t\t\tt->parent = t->real_parent;\n" "> \t\t\tif (t->pdeath_signal)" -1a1ee628c599d8fe3406959e2505cf2bc2dcde6c17d0c186df6cac9206d26fad +d55e7de1f88cb60e81f083c3cb53ba9a0aed6ca3a20ed45dab899bde5cde8b19
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.