From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH] gitweb: hack around CGI's list-context param() handling
Date: Tue, 18 Nov 2014 13:01:35 -0500 [thread overview]
Message-ID: <20141118180135.GA12461@peff.net> (raw)
In-Reply-To: <xmqqfvdgwful.fsf@gitster.dls.corp.google.com>
On Tue, Nov 18, 2014 at 09:58:26AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > As of CGI.pm's 4.08 release, the behavior to call
> > CGI::param() in a list context is deprecated (because it can
> > be potentially unsafe if called inside a hash constructor).
> > This cause gitweb to issue a warning for some of our code,
Oops, s/cause/causes/ of course.
-Peff
prev parent reply other threads:[~2014-11-18 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 17:10 [PATCH] gitweb: hack around CGI's list-context param() handling Jeff King
2014-11-18 17:58 ` Junio C Hamano
2014-11-18 18:01 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118180135.GA12461@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.