All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Turquette <mturquette@linaro.org>
To: Zhen Lei <thunder.leizhen@huawei.com>,
	"linux-kernel" <linux-kernel@vger.kernel.org>
Cc: "Zefan Li" <lizefan@huawei.com>,
	"Xinwei Hu" <huxinwei@huawei.com>,
	"Tianhong Ding" <dingtianhong@huawei.com>,
	"Kefeng Wang" <wangkefeng.wang@huawei.com>,
	"Zhen Lei" <thunder.leizhen@huawei.com>
Subject: Re: [PATCH 1/1] clk: delete a local variable's repeated assignment
Date: Tue, 18 Nov 2014 14:35:38 -0800	[thread overview]
Message-ID: <20141118223538.25314.21064@quantum> (raw)
In-Reply-To: <1415931040-9868-1-git-send-email-thunder.leizhen@huawei.com>

Quoting Zhen Lei (2014-11-13 18:10:40)
> It's the same to the next statement, "ret = clk->parent". I think compiler will
> optimize it, it's just not looking well.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

Applied.

Thanks,
Mike

> ---
>  drivers/clk/clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 4896ae9..5307225 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -1614,7 +1614,7 @@ static struct clk *__clk_init_parent(struct clk *clk)
> 
>         if (clk->num_parents == 1) {
>                 if (IS_ERR_OR_NULL(clk->parent))
> -                       ret = clk->parent = __clk_lookup(clk->parent_names[0]);
> +                       clk->parent = __clk_lookup(clk->parent_names[0]);
>                 ret = clk->parent;
>                 goto out;
>         }
> --
> 1.8.0
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

      reply	other threads:[~2014-11-18 22:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14  2:10 [PATCH 1/1] clk: delete a local variable's repeated assignment Zhen Lei
2014-11-18 22:35 ` Mike Turquette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141118223538.25314.21064@quantum \
    --to=mturquette@linaro.org \
    --cc=dingtianhong@huawei.com \
    --cc=huxinwei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.