All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"Allan, Bruce W" <bruce.w.allan@intel.com>,
	"Ronciak, John" <john.ronciak@intel.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	"Vick, Matthew" <matthew.vick@intel.com>
Subject: Re: [PATCH net-next 3/4] igb: enable internal PPS for the i210.
Date: Wed, 19 Nov 2014 21:26:04 +0100	[thread overview]
Message-ID: <20141119202604.GA22213@localhost.localdomain> (raw)
In-Reply-To: <1416425553.15933.32.camel@jekeller-desk1.amr.corp.intel.com>

On Wed, Nov 19, 2014 at 07:32:33PM +0000, Keller, Jacob E wrote:
> Good catch :)

(Well, my X session suddenly disappeared, and a kernel oops appeared in
the console... hard to overlook ;^)
 
> Did you see my concern about the reset path needing to fully restore the
> state since it is called after a hardware MAC reset which has cleared
> all these registers?

Yes, and that bit I copied from the first series a year ago. I don't
remember why, but IIRC that was necessary to let the SDP stuff work at
all. Maybe the reset function was called under different circumstances
back then. I'll take another look.

I find it a bit weird that the auxiliary functions don't work when the
interface or the link is down.

Thanks,
Richard

  reply	other threads:[~2014-11-19 20:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17 23:06 [PATCH net-next 0/4] igb: auxiliary PHC functions for the i210 Richard Cochran
2014-11-17 23:06 ` [PATCH net-next 1/4] igb: refactor time sync interrupt handling Richard Cochran
2014-11-17 23:06 ` [PATCH net-next 2/4] igb: do not clobber the TSAUXC bits on reset Richard Cochran
2014-11-17 23:22   ` Keller, Jacob E
2014-11-17 23:06 ` [PATCH net-next 3/4] igb: enable internal PPS for the i210 Richard Cochran
2014-11-17 23:24   ` Keller, Jacob E
2014-11-19  6:37   ` Richard Cochran
2014-11-19 19:32     ` Keller, Jacob E
2014-11-19 20:26       ` Richard Cochran [this message]
2014-11-19 21:06         ` Keller, Jacob E
2014-11-20  9:18           ` Richard Cochran
2014-11-20 21:28             ` Keller, Jacob E
2014-11-21  5:49               ` Richard Cochran
2014-11-17 23:06 ` [PATCH net-next 4/4] igb: enable auxiliary PHC functions " Richard Cochran
2014-11-17 23:28   ` Keller, Jacob E
2014-11-17 23:15 ` [PATCH net-next 0/4] igb: " Jeff Kirsher
2014-11-19  6:31   ` Richard Cochran
2014-11-19  8:43     ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141119202604.GA22213@localhost.localdomain \
    --to=richardcochran@gmail.com \
    --cc=bruce.w.allan@intel.com \
    --cc=davem@davemloft.net \
    --cc=jacob.e.keller@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=matthew.vick@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.