From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH for-4.5 2/4] xen: arm: correct off by one in xgene-storm's map_one_mmio Date: Wed, 19 Nov 2014 16:11:32 -0500 Message-ID: <20141119211132.GG20440@laptop.dumpdata.com> References: <1416329045.17982.27.camel@citrix.com> <1416329088-23328-2-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1416329088-23328-2-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, Clark Laughlin , Pranavkumar Sawargaonkar List-Id: xen-devel@lists.xenproject.org On Tue, Nov 18, 2014 at 04:44:46PM +0000, Ian Campbell wrote: > The callers pass the end as the pfn immediately *after* the last page to be > mapped, therefore adding one is incorrect and causes an additional page to be > mapped. > > At the same time correct the printing of the mfn values, zero-padding them to > 16 digits as for a paddr when they are frame numbers is just confusing. HA! I was just looking at that today and thought it was odd. Release-Acked-by: Konrad Rzeszutek Wilk > > Signed-off-by: Ian Campbell > --- > xen/arch/arm/platforms/xgene-storm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c > index 29c4752..38674cd 100644 > --- a/xen/arch/arm/platforms/xgene-storm.c > +++ b/xen/arch/arm/platforms/xgene-storm.c > @@ -45,9 +45,9 @@ static int map_one_mmio(struct domain *d, const char *what, > { > int ret; > > - printk("Additional MMIO %"PRIpaddr"-%"PRIpaddr" (%s)\n", > + printk("Additional MMIO %lx-%lx (%s)\n", > start, end, what); > - ret = map_mmio_regions(d, start, end - start + 1, start); > + ret = map_mmio_regions(d, start, end - start, start); > if ( ret ) > printk("Failed to map %s @ %"PRIpaddr" to dom%d\n", > what, start, d->domain_id); > -- > 1.7.10.4 >