diff for duplicates of <20141119233232.GA2627@bbox> diff --git a/a/1.txt b/N1/1.txt index 0afe291..32e8213 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -55,3 +55,46 @@ bio->bi_end_io. Indeed. I was terrible. Hope this is better. + +>From 635f22cac08f76b909ccc13b2de0b5d437eef5aa Mon Sep 17 00:00:00 2001 +From: Minchan Kim <minchan@kernel.org> +Date: Wed, 19 Nov 2014 08:57:49 +0900 +Subject: [PATCH] zram: add comment + +Signed-off-by: Minchan Kim <minchan@kernel.org> +--- + drivers/block/zram/zram_drv.c | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c +index decca6f161b8..6f1ceb14e64b 100644 +--- a/drivers/block/zram/zram_drv.c ++++ b/drivers/block/zram/zram_drv.c +@@ -975,6 +975,14 @@ static int zram_rw_page(struct block_device *bdev, sector_t sector, + err = zram_bvec_rw(zram, &bv, index, offset, rw); + out_unlock: + up_read(&zram->init_lock); ++ /* ++ * If I/O fails, just return error(ie, non-zero) without ++ * calling page_endio. ++ * It causes resubmit the I/O with bio request by upper functions ++ * of rw_page(e.g., swap_readpage, __swap_writepage) and ++ * bio->bi_end_io does things to handle the error ++ * (e.g., SetPageError, set_page_dirty and extra works). ++ */ + if (err == 0) + page_endio(page, rw, 0); + return err; +-- +2.0.0 + +> +> -- +> To unsubscribe, send a message with 'unsubscribe linux-mm' in +> the body to majordomo@kvack.org. For more info on Linux MM, +> see: http://www.linux-mm.org/ . +> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> + +-- +Kind regards, +Minchan Kim diff --git a/a/content_digest b/N1/content_digest index 3040380..3e8ff17 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -72,6 +72,49 @@ "\n" "Indeed. I was terrible.\n" "\n" - Hope this is better. + "Hope this is better.\n" + "\n" + ">From 635f22cac08f76b909ccc13b2de0b5d437eef5aa Mon Sep 17 00:00:00 2001\n" + "From: Minchan Kim <minchan@kernel.org>\n" + "Date: Wed, 19 Nov 2014 08:57:49 +0900\n" + "Subject: [PATCH] zram: add comment\n" + "\n" + "Signed-off-by: Minchan Kim <minchan@kernel.org>\n" + "---\n" + " drivers/block/zram/zram_drv.c | 8 ++++++++\n" + " 1 file changed, 8 insertions(+)\n" + "\n" + "diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c\n" + "index decca6f161b8..6f1ceb14e64b 100644\n" + "--- a/drivers/block/zram/zram_drv.c\n" + "+++ b/drivers/block/zram/zram_drv.c\n" + "@@ -975,6 +975,14 @@ static int zram_rw_page(struct block_device *bdev, sector_t sector,\n" + " \terr = zram_bvec_rw(zram, &bv, index, offset, rw);\n" + " out_unlock:\n" + " \tup_read(&zram->init_lock);\n" + "+\t/*\n" + "+\t * If I/O fails, just return error(ie, non-zero) without\n" + "+\t * calling page_endio.\n" + "+\t * It causes resubmit the I/O with bio request by upper functions\n" + "+\t * of rw_page(e.g., swap_readpage, __swap_writepage) and\n" + "+\t * bio->bi_end_io does things to handle the error\n" + "+\t * (e.g., SetPageError, set_page_dirty and extra works).\n" + "+\t */\n" + " \tif (err == 0)\n" + " \t\tpage_endio(page, rw, 0);\n" + " \treturn err;\n" + "-- \n" + "2.0.0\n" + "\n" + "> \n" + "> --\n" + "> To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "> the body to majordomo@kvack.org. For more info on Linux MM,\n" + "> see: http://www.linux-mm.org/ .\n" + "> Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>\n" + "\n" + "-- \n" + "Kind regards,\n" + Minchan Kim -64c59685378dfb11e27efbbc1c0e769c722383002da75d83ce44a1d5d7893398 +789f8431efa91849e5c3db58f4975fdaf1cd95b2df034d359146a58ed201503e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.