From: Christoph Hellwig <hch@infradead.org>
To: Rob Evers <revers@redhat.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH V4 3/5] scsi: Encapsulate scsi_do_report_luns
Date: Thu, 20 Nov 2014 00:20:44 -0800 [thread overview]
Message-ID: <20141120082044.GC29120@infradead.org> (raw)
In-Reply-To: <1416237730-1862-4-git-send-email-revers@redhat.com>
> +int scsi_do_report_luns(struct scsi_device *sdev, int length,
> + struct scsi_lun *lun_data, char *devname)
I would skip the do and call this scsi_report_luns. Also shouldn't this
function be marked static?
next prev parent reply other threads:[~2014-11-20 8:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 15:22 [PATCH V4 0/5] scsi: Configure number of LUs reported by 'report-luns' Rob Evers
2014-11-17 15:22 ` [PATCH V4 1/5] scsi: Fix scsi_report_lun_scan kmalloc flag Rob Evers
2014-11-20 8:17 ` Christoph Hellwig
2014-11-17 15:22 ` [PATCH V4 2/5] scsi: Fix scsi_report_lun_scan return when kmalloc fails Rob Evers
2014-11-20 8:19 ` Christoph Hellwig
2014-11-17 15:22 ` [PATCH V4 3/5] scsi: Encapsulate scsi_do_report_luns Rob Evers
2014-11-20 8:20 ` Christoph Hellwig [this message]
2014-11-17 15:22 ` [PATCH V4 4/5] scsi: Change default value of max_report_luns to 16k-1 Rob Evers
2014-11-20 9:23 ` Christoph Hellwig
2014-11-17 15:22 ` [PATCH V4 5/5] scsi: Use set/get_unaligned_be32 in report_luns Rob Evers
2014-11-20 18:41 ` [PATCH V4 0/5] scsi: Configure number of LUs reported by 'report-luns' Rob Evers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120082044.GC29120@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=revers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.