From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/atomic: Add missing ERR_PTR casting Date: Thu, 20 Nov 2014 09:58:52 +0100 Message-ID: <20141120085851.GC23043@ulmo> References: <1416473615-17267-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2052204480==" Return-path: In-Reply-To: <1416473615-17267-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Dave Airlie List-Id: dri-devel@lists.freedesktop.org --===============2052204480== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FsscpQKzF/jJk6ya" Content-Disposition: inline --FsscpQKzF/jJk6ya Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 20, 2014 at 09:53:35AM +0100, Daniel Vetter wrote: > This is an oversight from >=20 > commit f52b69f1ecfdd7ef6867a257620258c09e569552 > Author: Daniel Vetter > Date: Wed Nov 19 18:38:08 2014 +0100 >=20 > drm/atomic: Don't overrun the connector array when hotplugging >=20 > Cc: Dave Airlie > Cc: Rob Clark > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_atomic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index 3624632084e2..d3b46746b611 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -318,7 +318,7 @@ drm_atomic_get_connector_state(struct drm_atomic_stat= e *state, > */ > if (index >=3D state->num_connector) { > DRM_DEBUG_KMS("Hot-added connector would overflow state array, restart= ing\n"); > - return -EAGAIN; > + return ERR_PTR(-EAGAIN); > } > =20 > if (state->connector_states[index]) =3D) Reviewed-by: Thierry Reding --FsscpQKzF/jJk6ya Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUba1LAAoJEN0jrNd/PrOh6NoQALqp9kZe6aQKA2qsqSJKQiy7 q3BusyvgGJo1tUcEoUuVc9JDIM1IYyrcHGGZiiEPrY4g6aZZGkWbSvSVnm9LwliU JIBERyd9bt+ZD1MpPDwLvfxnCDlCTgWdHtSgpCO4rj35fp9GkbaqE2d6y/SKMM0p yc7oXsaIyiufDatHUmPZlu+nXi3RKljAEGCMoN+NlRcJ9cf+Fd3ZOjn9u/nrxR8e g15sU0fQIsfd/Mt+g7r3vzidcgteNRyRsBlarf53pJh72S8V3HHGa/6Br3L7tXc6 wxo11ygpJd0CEd7p6SesWFAPUGI21yGq5PvixuaqiQz3QluxRnOsjySCzdgTOpoY Uo8e++JZtLyROgcoVp0ZwmUajTyUQYfvMTd21ff9owbIgEcBQZj1ht4pjTrgVIRI IlqL7vDwvYQq+9zumAPerCGQjWA9cxoacmkt9cPrtJz/csK0smMibcCfxk8CtQXG D5WML2lMyAofc3o8nvKak6At3B8E/HA800eioCyZHsZVrbdptlq4aVH4/8HdFmMS 0D+QaMYRac0PI6lKu4sob+l1GrezAjZ9uxGSEhuEuaNHKRuv1r0sRMLVOC8Z60pv imNm0iXTBMk+4v4UX3pv/gmRoBd+mwCq/e1QVlu9UimCjPpWiVQ0s4YkzHAAEh8H K4hjC29xx6R4vb2cPiuk =eG98 -----END PGP SIGNATURE----- --FsscpQKzF/jJk6ya-- --===============2052204480== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============2052204480==--