All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: linux.nics@intel.com, e1000-devel@lists.sourceforge.net,
	netdev@vger.kernel.org, bruce.w.allan@intel.com,
	john.ronciak@intel.com, davem@davemloft.net
Subject: Re: [patch net-next] i40e: remove dead fdb code
Date: Thu, 20 Nov 2014 09:39:46 -0800	[thread overview]
Message-ID: <20141120093946.00000d30@unknown> (raw)
In-Reply-To: <1416489029-1929-1-git-send-email-jiri@resnulli.us>

On Thu, 20 Nov 2014 14:10:29 +0100
Jiri Pirko <jiri@resnulli.us> wrote:

> This code is not used now and also it contains some weird ifdefs. So
> remove it for now. It can be added when needed.
> 

First, thanks for looking at our code.

but, NAK, the code just needs to have the #ifdefs removed.

In addition the fdb_del and fdb_dump functions are un-necessary and
were submitted by mistake.

I will draft up a patch today and send it (and Jeff can take it through
Jeff Kirsher's i40e tree, if thats okay with DaveM)

Thanks, 
 Jesse

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

  reply	other threads:[~2014-11-20 17:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 13:10 [patch net-next] i40e: remove dead fdb code Jiri Pirko
2014-11-20 17:39 ` Jesse Brandeburg [this message]
2014-11-21  7:44   ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141120093946.00000d30@unknown \
    --to=jesse.brandeburg@intel.com \
    --cc=bruce.w.allan@intel.com \
    --cc=davem@davemloft.net \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jiri@resnulli.us \
    --cc=john.ronciak@intel.com \
    --cc=linux.nics@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.