Re: [Qemu-devel] [PATCH] migration: static variables will not be reset at second migration

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Amit Shah (amit.shah@redhat.com) wrote:
> On (Thu) 20 Nov 2014 [19:39:11], Gonglei wrote:
> > >>>> The static variables in migration_bitmap_sync will not be reset in
> > >>>> the case of a second attempted migration.
> > >>>>
> > >>>> Signed-off-by: ChenLiang <chenliang88@huawei.com>
> > >>>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> > >>>
> > >>> Good catch.  Applied..
> > >>>
> > >>
> > >> Hi, Juan? Ping... please :)
> > > 
> > > Juan, what happened to this patch?
> >
> > Nearly for half a year, I forgot it completely :(
> > Thanks for your prompt, Paolo.
> 
> Yeah; unfortunate.
> 
> I feel the patch could've been done in a better way, but since it's
> been a while...
> 
> Paolo, Dave, can you please give me r-b and I'll pick it up for 2.2.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Note that there are some more statics that have ended up in migration_bitmap_sync
since that patch landed, but still it would be good to get this fix going.

Dave

> 
> Thanks,
> 
> 		Amit
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK