From: Eduardo Habkost <ehabkost@redhat.com>
To: Don Slutz <dslutz@verizon.com>
Cc: Anthony Liguori <aliguori@amazon.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 v3 1/1] -machine vmport=auto: Fix handling of VMWare ioport emulation for xen
Date: Thu, 20 Nov 2014 13:29:41 -0200 [thread overview]
Message-ID: <20141120152941.GL3243@thinpad.lan.raisama.net> (raw)
In-Reply-To: <546E05D5.7080005@terremark.com>
On Thu, Nov 20, 2014 at 10:16:37AM -0500, Don Slutz wrote:
> On 11/20/14 04:13, Michael S. Tsirkin wrote:
> >On Wed, Nov 19, 2014 at 09:11:41PM -0700, Eric Blake wrote:
[...]
> >>>+{ 'enum': 'vmport',
> >>All other enums in .json files are named in StudlyCaps. Please name
> >>this starting with a capital letter, and reserve all-lower-case names
> >>for commands and built-in types.
> >Hi Eric,
> >The values here are not vmport-specific.
> >Do you think we should have a generic OnOffAuto type?
> >
>
> I am waiting for a a clear direction on how to go.
>
> VMPortConfig, Tristate, and OnOffAuto are the 3 names
> I am tracking.
I prefer a non-vmport-specific name. OnOffAuto is more descriptive than
Tristate, and is good enough to me.
--
Eduardo
next prev parent reply other threads:[~2014-11-20 15:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 0:38 [Qemu-devel] [BUGFIX][PATCH for 2.2 v3 1/1] -machine vmport=auto: Fix handling of VMWare ioport emulation for xen Don Slutz
2014-11-20 0:58 ` Eduardo Habkost
2014-11-20 6:04 ` Paolo Bonzini
2014-11-20 10:00 ` Dr. David Alan Gilbert
2014-11-20 11:00 ` Paolo Bonzini
2014-11-20 15:01 ` Eduardo Habkost
2014-11-20 16:48 ` Don Slutz
2014-11-20 15:07 ` Don Slutz
2014-11-20 15:10 ` Paolo Bonzini
2014-11-20 15:02 ` Don Slutz
2014-11-20 4:11 ` Eric Blake
2014-11-20 9:13 ` Michael S. Tsirkin
2014-11-20 15:16 ` Don Slutz
2014-11-20 15:29 ` Eduardo Habkost [this message]
2014-11-20 8:44 ` Michael S. Tsirkin
2014-11-20 16:51 ` Eric Blake
2014-11-20 17:40 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120152941.GL3243@thinpad.lan.raisama.net \
--to=ehabkost@redhat.com \
--cc=aliguori@amazon.com \
--cc=dgilbert@redhat.com \
--cc=dslutz@verizon.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.