From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrWdP-0005yV-5K for qemu-devel@nongnu.org; Thu, 20 Nov 2014 13:39:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrWdI-0000Z0-TH for qemu-devel@nongnu.org; Thu, 20 Nov 2014 13:39:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrWdI-0000Yu-LZ for qemu-devel@nongnu.org; Thu, 20 Nov 2014 13:39:08 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAKId6hC014742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Nov 2014 13:39:07 -0500 Date: Thu, 20 Nov 2014 19:39:03 +0100 From: Kevin Wolf Message-ID: <20141120183903.GI9266@noname.redhat.com> References: <1416227466-29491-1-git-send-email-mreitz@redhat.com> <1416227466-29491-4-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416227466-29491-4-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 3/3] iotests: Use -qmp-pretty in 067 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Paolo Bonzini , qemu-devel@nongnu.org, Stefan Hajnoczi Am 17.11.2014 um 13:31 hat Max Reitz geschrieben: > 067 invokes query-block, resulting in a reference output with really > long lines (which may pose a problem in email patches and always poses a > problem when the output changes, because it is hard to see what has > actually changed). Use -qmp-pretty to mitigate this issue. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/067 | 2 +- > tests/qemu-iotests/067.out | 779 +++++++++++++++++++++++++++++++++++++++++---- > 2 files changed, 723 insertions(+), 58 deletions(-) Hm, when I tried to rebase my query-block patch that adds cache information, I noticed that I get a trailing space on every line of the JSON dump, which isn't there in this patch. So 'cp 067.out.bad 067.out' ended up changing every single line. :-/ Did you postprocess the reference output or do really get it without trailing whitespace? Kevin