From: Pavel Machek <pavel@ucw.cz>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: j.anaszewski@samsung.com, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, linux-doc@vger.kernel.org,
cooloney@gmail.com, rpurdie@rpsys.net, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net
Subject: Re: [PATCH] Add attributes neccessary for LED flashes to devicetree/bindings/leds/common.txt
Date: Thu, 20 Nov 2014 21:53:50 +0100 [thread overview]
Message-ID: <20141120205350.GB19174@amd> (raw)
In-Reply-To: <20141120150349.GZ8907@valkosipuli.retiisi.org.uk>
Hi!
On Thu 2014-11-20 17:03:49, Sakari Ailus wrote:
> On Thu, Nov 20, 2014 at 02:17:13PM +0100, Pavel Machek wrote:
> > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> > index 2d88816..e9acbbc 100644
> > --- a/Documentation/devicetree/bindings/leds/common.txt
> > +++ b/Documentation/devicetree/bindings/leds/common.txt
> > @@ -14,6 +14,15 @@ Optional properties for child nodes:
> > "ide-disk" - LED indicates disk activity
> > "timer" - LED flashes at a fixed, configurable rate
> >
> > +- max-microamp : maximum intensity in microamperes of the LED
> > + (torch LED for flash devices)
> > +- flash-max-microamp : maximum intensity in microamperes of the
> > + flash LED; it is mandatory if the LED should
> > + support the flash mode
> > +- flash-timeout-microsec : timeout in microseconds after which the flash
> > + LED is turned off
>
> It might be good to add a note that these may be arrays, depending on the
> device.
No, they really can't be arrays. AFAICT common.txt describes single
LED, not array of them, and I don't think it is good idea to change
that.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-11-20 20:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 13:17 [PATCH] Add attributes neccessary for LED flashes to devicetree/bindings/leds/common.txt Pavel Machek
2014-11-20 13:38 ` Jacek Anaszewski
2014-11-20 14:48 ` Jacek Anaszewski
2014-11-20 20:52 ` Pavel Machek
2014-11-21 8:15 ` Jacek Anaszewski
2014-11-24 22:53 ` Pavel Machek
2014-11-26 6:09 ` Bryan Wu
2014-12-03 15:51 ` Pavel Machek
2014-12-03 16:10 ` Sakari Ailus
2014-12-03 18:58 ` Pavel Machek
2014-11-20 19:19 ` Pavel Machek
2014-11-20 15:03 ` Sakari Ailus
2014-11-20 20:53 ` Pavel Machek [this message]
2014-11-21 7:39 ` Sakari Ailus
2014-11-26 12:47 ` Pavel Machek
2014-11-21 7:38 ` Jacek Anaszewski
2014-11-21 7:40 ` Sakari Ailus
2014-12-03 16:03 ` Sakari Ailus
2014-11-26 7:57 ` Jacek Anaszewski
2014-12-03 18:57 ` [PATCH w/ acks] DT: leds: Add flash LED devices related properties Pavel Machek
2014-12-03 19:03 ` Bryan Wu
2014-12-20 15:02 ` Pavel Machek
2014-12-22 2:27 ` Rob Herring
2014-12-22 11:45 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120205350.GB19174@amd \
--to=pavel@ucw.cz \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=j.anaszewski@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.