Re: [PATCH 1/2] drm/exynos: fix null pointer dereference issue

[Gustavo Padovan <gustavo@padovan.org>]

2014-11-13 Inki Dae <inki.dae@samsung.com>:

> This patch fixes null pointer dereference issue incurred
> when ipp driver is enabled and Exynos drm driver is closed.
> 
> Non kms driver should register its own sub driver to setup necessary
> resources, which is done by load(). So null pointer dereference
> occurs when ipp driver is enabled and Exynos drm driver is closed
> because ipp core device is registered after component_master_add_with_match
> call.
> 
> This patch makes exynos_drm_device_subdrv_probe() to be called after all non
> kms drivers are registered.

This patch is breaking exynos initialization, exynos_drm_device_subdrv_probe()
needs the drvdata but it is still NULL at this point which make the whole
exynos init fails. The drvdata is only set in exynos_drm_load() so we need
call exynos_drm_device_subdrv_probe() after that.

Do you have the crash output for this? What is the issue you are fixing?
Usually you should add this kind of information to you commit message, it
helps us understand what you are fixing, specially in cases when a regression
is introduced, like this patch for example

	Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel