From: Christoph Hellwig <hch@infradead.org>
To: venkateshs@google.com
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, James Smart <james.smart@emulex.com>,
Mike Christie <michaelc@cs.wisc.edu>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH 2/7] scsi: avoid ->change_queue_depth indirection for queue full tracking
Date: Fri, 21 Nov 2014 02:19:55 -0800 [thread overview]
Message-ID: <20141121101955.GA3926@infradead.org> (raw)
In-Reply-To: <20141113194719.GA21540@google.com>
On Thu, Nov 13, 2014 at 07:47:19PM +0000, venkateshs@google.com wrote:
> On Thu, Nov 13, 2014 at 06:59:01PM +0100, Christoph Hellwig wrote:
> >All drivers use the implementation for ramping the queue up and down, so
> >instead of overloading the change_queue_depth method call the
> >implementation diretly if the driver opts into it by setting the
> >track_queue_depth flag in the host template.
> >
> >Note that a few drivers validated the new queue depth in their
> >change_queue_depth method, but as we never go over the queue depth
> >set during slave_configure or the sysfs file this isn't nessecary
> >and can safely be removed.
> >
> >Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> This patch plus the change to remove the 'tagged' argument to
> scsi_adjust_queue_depth() form a nice cleanup.
>
> Reviewed-by: Venkatesh Srinivas <venkateshs@google.com>
Any chance to get a review for the other patches in the series as well?
next prev parent reply other threads:[~2014-11-21 10:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 17:58 split ->change_queue_depth Christoph Hellwig
2014-11-13 17:59 ` [PATCH 1/7] lpfc: remove queue_depth events Christoph Hellwig
2014-11-20 7:27 ` Hannes Reinecke
2014-11-20 19:16 ` James Smart
2014-11-21 10:20 ` Christoph Hellwig
2014-11-13 17:59 ` [PATCH 2/7] scsi: avoid ->change_queue_depth indirection for queue full tracking Christoph Hellwig
2014-11-13 19:47 ` venkateshs
2014-11-21 10:19 ` Christoph Hellwig [this message]
2014-11-20 7:34 ` Hannes Reinecke
2014-11-13 17:59 ` [PATCH 3/7] scsi: don't allow setting of queue_depth bigger than can_queue Christoph Hellwig
2014-11-20 7:35 ` Hannes Reinecke
2014-11-13 17:59 ` [PATCH 4/7] scsi: drop reason argument from ->change_queue_depth Christoph Hellwig
2014-11-20 7:39 ` Hannes Reinecke
2014-11-13 17:59 ` [PATCH 5/7] mpt2sas: simplify ->change_queue_depth Christoph Hellwig
2014-11-20 7:39 ` Hannes Reinecke
2014-11-13 17:59 ` [PATCH 6/7] mpt3sas: " Christoph Hellwig
2014-11-20 7:40 ` Hannes Reinecke
2014-11-13 17:59 ` [PATCH 7/7] vmw_pscsi: " Christoph Hellwig
2014-11-20 7:40 ` Hannes Reinecke
2014-11-20 6:13 ` split ->change_queue_depth Christoph Hellwig
2014-11-24 5:51 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121101955.GA3926@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hch@lst.de \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=venkateshs@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.