Re: [meta-oe]]PATCH] dfu-util: Switch from using a gitorious generated download to using the git repository to avoid potential checksum mismatches if the generated download changes

From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Cc: Chris Morgan <cmorgan@cybexintl.com>
Subject: Re: [meta-oe]]PATCH] dfu-util: Switch from using a gitorious generated download to using the git repository to avoid potential checksum mismatches if the generated download changes
Date: Fri, 21 Nov 2014 15:04:34 +0100	[thread overview]
Message-ID: <20141121140434.GG2163@jama> (raw)
In-Reply-To: <1416420840-2194-1-git-send-email-cmorgan@cybexintl.com>

[-- Attachment #1: Type: text/plain, Size: 2533 bytes --]

On Wed, Nov 19, 2014 at 01:14:00PM -0500, Chris Morgan wrote:
> ---
>  meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Thanks for PATCHv2, the old version was failing as forseen:

ERROR: Fetcher failure for URL: 'https://gitorious.org/dfu-util/dfu-util/archive/a0a3668e0571a9b007f7d62b01e7dcfd7754ce50.tar.gz'. Checksum mismatch!
File: '/home/jenkins/oe/world/shr-core/downloads/a0a3668e0571a9b007f7d62b01e7dcfd7754ce50.tar.gz' has md5 checksum ccb84df0c2c4c27dc9b975af81a50bdb when 1de724551604bce1962960b7a301cc08 was expected
File: '/home/jenkins/oe/world/shr-core/downloads/a0a3668e0571a9b007f7d62b01e7dcfd7754ce50.tar.gz' has sha256 checksum 5d051e1570c3adf1d6c473936a4881fae12cc5a6fd9b5cf013afc1d67a604dbd when 5d253f924fd29bc13054b664bba9aa86b865299971195969478253c1775b7e56 was expected
If this change is expected (e.g. you have upgraded to a new version without updating the checksums) then you can use these lines within the recipe:
SRC_URI[md5sum] = "ccb84df0c2c4c27dc9b975af81a50bdb"
SRC_URI[sha256sum] = "5d051e1570c3adf1d6c473936a4881fae12cc5a6fd9b5cf013afc1d67a604dbd"
Otherwise you should retry the download and/or check with upstream to determine if the file has become corrupted or otherwise unexpectedly modified.

I'll squash both changes to one so that the master stays bisect-able

> 
> diff --git a/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb b/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
> index c706fd1..7f06f8f 100644
> --- a/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
> +++ b/meta-oe/recipes-support/dfu-util/dfu-util_0.7.bb
> @@ -4,12 +4,12 @@ AUTHOR = "Harald Welte <laforge@openmoko.org>"
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>  
> -S = "${WORKDIR}/${BPN}-${BPN}"
> +S = "${WORKDIR}/git"
>  
> -REV="a0a3668e0571a9b007f7d62b01e7dcfd7754ce50"
> -SRC_URI = "https://gitorious.org/${BPN}/${BPN}/archive/${REV}.tar.gz \
> +SRC_URI = "git://gitorious.org/dfu-util/dfu-util.git \
>      file://0001-configure.ac-Don-t-check-for-usbpath.patch \
>  "
> +SRCREV="a0a3668e0571a9b007f7d62b01e7dcfd7754ce50"
>  
>  inherit autotools pkgconfig
>  
> -- 
> 1.9.3
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]