From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [for-xen-4.5 PATCH v2 2/2] dpci: Add ZOMBIE state to allow the softirq to finish with the dpci_pirq. Date: Fri, 21 Nov 2014 10:14:35 -0500 Message-ID: <20141121151435.GE2886@laptop.dumpdata.com> References: <1416435695-23784-1-git-send-email-konrad.wilk@oracle.com> <1416435695-23784-3-git-send-email-konrad.wilk@oracle.com> <546DD6BF0200007800049471@smtp.nue.novell.com> <20141120195133.GE25423@laptop.dumpdata.com> <546EFD1502000078000499E3@smtp.nue.novell.com> <1346109865.20141121135124@eikelenboom.it> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xrpv3-0006g6-IA for xen-devel@lists.xenproject.org; Fri, 21 Nov 2014 15:14:45 +0000 Content-Disposition: inline In-Reply-To: <1346109865.20141121135124@eikelenboom.it> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Sander Eikelenboom Cc: andrew.cooper3@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Fri, Nov 21, 2014 at 01:51:24PM +0100, Sander Eikelenboom wrote: > > Friday, November 21, 2014, 12:50:16 PM, you wrote: > > > On November 21, 2014 2:51:33 AM EST, Jan Beulich wrote: > >>>>> On 20.11.14 at 20:51, wrote: > >>> @@ -669,7 +670,7 @@ static void hvm_dirq_assist(struct domain *d, > >>struct hvm_pirq_dpci *pirq_dpci) > >>> ASSERT(d->arch.hvm_domain.irq.dpci); > >>> > >>> spin_lock(&d->event_lock); > >>> - if ( pirq_dpci->state ) > >>> + if ( test_and_clear_bool(pirq_dpci->masked) ) > >>> { > >>> struct pirq *pirq = dpci_pirq(pirq_dpci); > >>> const struct dev_intx_gsi_link *digl; > >> > >>So this now guards solely against the timeout enforced EOI? Why do > >>you no longer need to guard against cancellation (i.e. why isn't this > >>looking at both ->state and ->masked)? > >> > > > The previous state check was superfluous as the dpci_softirq would check for the valid STATE_ before calling hvm_dirq_assist (and deal with cancellation). > > > I actually had an cleanup patch that would have removed the 'if (pirq_dpci->state) ' and move the code for Xen 4.6. > > > Anyhow waiting to see if Sander was able to test with this patch. > > >>Jan > > Hi Konrad / Jan, > > I have tested it for 3 hours now, no host crash so far (even after applying some > extra stress to the guest). Yeey! Thank you for being so flexible and willing to test these patches out! > > -- > Sander > >