From mboxrd@z Thu Jan  1 00:00:00 1970
From: andrew@lunn.ch (Andrew Lunn)
Date: Fri, 21 Nov 2014 21:22:53 +0100
Subject: [PATCHv5 05/10] arm: mvebu: define and use common Armada 370 SPI
 pinctrl settings
In-Reply-To: <a0eb580b7cc0f7cf39f1a69f0cc5747bded66300.1416598537.git.arno@natisbad.org>
References: <cover.1416598536.git.arno@natisbad.org>
 <a0eb580b7cc0f7cf39f1a69f0cc5747bded66300.1416598537.git.arno@natisbad.org>
Message-ID: <20141121202253.GE20238@lunn.ch>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Arnaud

> diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
> index 90e1286d414f..f1284ae0cddd 100644
> --- a/arch/arm/boot/dts/armada-370.dtsi
> +++ b/arch/arm/boot/dts/armada-370.dtsi
> @@ -197,6 +197,20 @@
>  				status = "disabled";
>  			};
>  
> +			/*
> +			 * Default SPI pinctrl setting, can be overwritten on
> +			 * board level if a different configuration is used.
> +			 */
> +			spi0: spi at 10600 {
> +				pinctrl-0 = <&spi0_pins1>;
> +				pinctrl-names = "default";
> +			};
> +
> +			spi1: spi at 10680 {
> +				pinctrl-0 = <&spi1_pins>;
> +				pinctrl-names = "default";
> +			};
> +

Again, ordering. It looks like these should be between l2-cache and i2c0.

       Andrew

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Subject: Re: [PATCHv5 05/10] arm: mvebu: define and use common Armada 370 SPI
 pinctrl settings
Date: Fri, 21 Nov 2014 21:22:53 +0100
Message-ID: <20141121202253.GE20238@lunn.ch>
References: <cover.1416598536.git.arno@natisbad.org>
 <a0eb580b7cc0f7cf39f1a69f0cc5747bded66300.1416598537.git.arno@natisbad.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <a0eb580b7cc0f7cf39f1a69f0cc5747bded66300.1416598537.git.arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
To: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>, Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>, Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>, Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>, Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>, Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
List-Id: devicetree@vger.kernel.org

Hi Arnaud

> diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
> index 90e1286d414f..f1284ae0cddd 100644
> --- a/arch/arm/boot/dts/armada-370.dtsi
> +++ b/arch/arm/boot/dts/armada-370.dtsi
> @@ -197,6 +197,20 @@
>  				status = "disabled";
>  			};
>  
> +			/*
> +			 * Default SPI pinctrl setting, can be overwritten on
> +			 * board level if a different configuration is used.
> +			 */
> +			spi0: spi@10600 {
> +				pinctrl-0 = <&spi0_pins1>;
> +				pinctrl-names = "default";
> +			};
> +
> +			spi1: spi@10680 {
> +				pinctrl-0 = <&spi1_pins>;
> +				pinctrl-names = "default";
> +			};
> +

Again, ordering. It looks like these should be between l2-cache and i2c0.

       Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html