From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: sunwxg <sun.wxg@gmail.com>
Cc: Peng Tao <bergwolf@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:lustre:lnet:lnet Function must be static
Date: Sat, 22 Nov 2014 11:01:12 -0800 [thread overview]
Message-ID: <20141122190112.GA29470@kroah.com> (raw)
In-Reply-To: <1416144284-31138-2-git-send-email-sun.wxg@gmail.com>
On Sun, Nov 16, 2014 at 09:24:44PM +0800, sunwxg wrote:
> From: Sun Wang <sun.wxg@gmail.com>
>
> Function must be static if function will not be used in other files.
>
> Signed-off-by: Sun Wang <sun.wxg@gmail.com>
>
> ---
> drivers/staging/lustre/lnet/lnet/{module.c.org => module.c} | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/module.c.org b/drivers/staging/lustre/lnet/lnet/module.c
> index e84d59d..4ca7b1d 100644
> --- a/drivers/staging/lustre/lnet/lnet/module.c.org
> +++ b/drivers/staging/lustre/lnet/lnet/module.c
> @@ -43,7 +43,7 @@ MODULE_PARM_DESC(config_on_load, "configure network at module load");
>
> static struct mutex lnet_config_mutex;
>
> -int
> +static int
> lnet_configure(void *arg)
> {
> /* 'arg' only there so I can be passed to cfs_create_thread() */
Does not apply :(
prev parent reply other threads:[~2014-11-22 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 13:24 [PATCH] staging:lustre:lnet:lnet Function must be static sunwxg
2014-11-22 19:01 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141122190112.GA29470@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bergwolf@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sun.wxg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.