* [PATCH] staging:lustre:lnet:lnet Function must be static
@ 2014-11-16 13:24 sunwxg
2014-11-22 19:01 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: sunwxg @ 2014-11-16 13:24 UTC (permalink / raw)
To: Greg Kroah-Hartman, Peng Tao, devel; +Cc: Sun Wang, linux-kernel
From: Sun Wang <sun.wxg@gmail.com>
Function must be static if function will not be used in other files.
Signed-off-by: Sun Wang <sun.wxg@gmail.com>
---
drivers/staging/lustre/lnet/lnet/{module.c.org => module.c} | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/module.c.org b/drivers/staging/lustre/lnet/lnet/module.c
index e84d59d..4ca7b1d 100644
--- a/drivers/staging/lustre/lnet/lnet/module.c.org
+++ b/drivers/staging/lustre/lnet/lnet/module.c
@@ -43,7 +43,7 @@ MODULE_PARM_DESC(config_on_load, "configure network at module load");
static struct mutex lnet_config_mutex;
-int
+static int
lnet_configure(void *arg)
{
/* 'arg' only there so I can be passed to cfs_create_thread() */
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging:lustre:lnet:lnet Function must be static
2014-11-16 13:24 [PATCH] staging:lustre:lnet:lnet Function must be static sunwxg
@ 2014-11-22 19:01 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2014-11-22 19:01 UTC (permalink / raw)
To: sunwxg; +Cc: Peng Tao, devel, linux-kernel
On Sun, Nov 16, 2014 at 09:24:44PM +0800, sunwxg wrote:
> From: Sun Wang <sun.wxg@gmail.com>
>
> Function must be static if function will not be used in other files.
>
> Signed-off-by: Sun Wang <sun.wxg@gmail.com>
>
> ---
> drivers/staging/lustre/lnet/lnet/{module.c.org => module.c} | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/module.c.org b/drivers/staging/lustre/lnet/lnet/module.c
> index e84d59d..4ca7b1d 100644
> --- a/drivers/staging/lustre/lnet/lnet/module.c.org
> +++ b/drivers/staging/lustre/lnet/lnet/module.c
> @@ -43,7 +43,7 @@ MODULE_PARM_DESC(config_on_load, "configure network at module load");
>
> static struct mutex lnet_config_mutex;
>
> -int
> +static int
> lnet_configure(void *arg)
> {
> /* 'arg' only there so I can be passed to cfs_create_thread() */
Does not apply :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-22 19:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-16 13:24 [PATCH] staging:lustre:lnet:lnet Function must be static sunwxg
2014-11-22 19:01 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.