From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 13/51] samba: use <pkg>_INSTALL_INIT_SYSV mechanism
Date: Mon, 24 Nov 2014 07:27:33 +0200 [thread overview]
Message-ID: <20141124052733.GD2241@tarshish> (raw)
In-Reply-To: <20141124044922.GB2241@tarshish>
Hi Thomas,
On Mon, Nov 24, 2014 at 06:49:22AM +0200, Baruch Siach wrote:
> On Sun, Nov 23, 2014 at 09:38:45PM +0100, Thomas Petazzoni wrote:
> > +define SAMBA_INSTALL_INIT_SYSV
> > + # install start/stop script
> > + @if [ ! -f $(TARGET_DIR)/etc/init.d/S91smb ]; then \
> > + $(INSTALL) -m 0755 -D package/samba/S91smb $(TARGET_DIR)/etc/init.d/S91smb; \
> > + fi
> > +endef
>
> Why not install the init script unconditionally like you did in vsftpd?
The same comment goes for the input-event-daemon, netatalk, and gpsd patches
in this series.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2014-11-24 5:27 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 20:38 [Buildroot] [PATCH 00/51] Misc trivial improvements Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 01/51] vsftpd: use <pkg>_INSTALL_INIT_SYSV and rename init script Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 02/51] vsftpd: don't install manpages Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 03/51] vsftpd: rename patches to the new naming convention Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 04/51] radvd: use <pkg>_INSTALL_INIT_SYSV Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 05/51] thttpd: use the <pkg>_INSTALL_INIT_SYSV mechanism Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 06/51] busybox: use " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 07/51] portmap: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 08/51] portmap: don't install manpages Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 09/51] portmap: improve installation of binaries Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 10/51] stunnel: use the <pkg>_INSTALL_INIT_SYSV mechanism Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 11/51] gdk-pixbuf: use " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 12/51] proftpd: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 13/51] samba: " Thomas Petazzoni
2014-11-24 4:49 ` Baruch Siach
2014-11-24 5:27 ` Baruch Siach [this message]
2014-11-24 20:45 ` Thomas Petazzoni
2014-11-24 20:47 ` Peter Korsgaard
2014-11-23 20:38 ` [Buildroot] [PATCH 14/51] input-event-daemon: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 15/51] ifplugd: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 16/51] nfs-utils: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 17/51] netatalk: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 18/51] mongoose: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 19/51] gpsd: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 20/51] olsr: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 21/51] pango: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 22/51] xapp_xdm: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 23/51] tftpd: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 24/51] openvpn: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 25/51] tinyhttpd: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 26/51] at: " Thomas Petazzoni
2014-11-23 20:38 ` [Buildroot] [PATCH 27/51] mpd: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 28/51] snowball-init: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 29/51] wipe: don't install man pages Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 30/51] ndisc6: remove man page related code Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 31/51] tree: don't install man page Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 32/51] iostat: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 33/51] iostat: remove legacy code Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 34/51] pptp-linux: don't install man page Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 35/51] gnupg: don't both removing a " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 36/51] rp-pppoe: don't install man pages Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 37/51] rp-pppoe: bail out of installation fails Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 38/51] alsa-utils: add error handling to for loop Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 39/51] coreutils: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 40/51] ebtables: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 41/51] flot: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 42/51] googlefontdirectory: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 43/51] gptfdisk: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 44/51] irda-utils: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 45/51] jimtcl: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 46/51] live555: " Thomas Petazzoni
2014-11-24 5:25 ` Baruch Siach
2014-11-24 20:42 ` Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 47/51] lockfile-progs: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 48/51] qt5base: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 49/51] qtuio: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 50/51] sound-theme-borealis: " Thomas Petazzoni
2014-11-23 20:39 ` [Buildroot] [PATCH 51/51] xenomai: " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124052733.GD2241@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.