From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org,
Paulo Zanoni <paulo.r.zanoni@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Only warn the first time we attempt to mmio whilst suspended
Date: Mon, 24 Nov 2014 10:38:28 +0100 [thread overview]
Message-ID: <20141124093828.GL25711@phenom.ffwll.local> (raw)
In-Reply-To: <1416816192-15484-1-git-send-email-chris@chris-wilson.co.uk>
On Mon, Nov 24, 2014 at 08:03:12AM +0000, Chris Wilson wrote:
> In all likelihood we will do a few hundred errnoneous register
> operations if we do a single invalid register access whilst the device
> is suspended. As each instance causes a WARN, this floods the system
> logs and can make the system unresponsive.
>
> The warning was first introduced in
> commit b2ec142cb0101f298f8e091c7d75b1ec5b809b65
> Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Date: Fri Feb 21 13:52:25 2014 -0300
>
> drm/i915: call assert_device_not_suspended at gen6_force_wake_work
>
> and despite the claims the WARN is still encountered in the wild today.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: stable@vger.kernel.org
I'll pick this up queued for 3.19 (but haven't done the split yet).
-Daniel
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 1a3e485a4f97..f0230b0e8e11 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -43,8 +43,8 @@
> static void
> assert_device_not_suspended(struct drm_i915_private *dev_priv)
> {
> - WARN(HAS_RUNTIME_PM(dev_priv->dev) && dev_priv->pm.suspended,
> - "Device suspended\n");
> + WARN_ONCE(HAS_RUNTIME_PM(dev_priv->dev) && dev_priv->pm.suspended,
> + "Device suspended\n");
> }
>
> static void __gen6_gt_wait_for_thread_c0(struct drm_i915_private *dev_priv)
> --
> 2.1.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-24 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 8:03 [PATCH] drm/i915: Only warn the first time we attempt to mmio whilst suspended Chris Wilson
2014-11-24 9:38 ` Daniel Vetter [this message]
2014-11-24 13:17 ` [PATCH] drm/i915: Only warn the first time we attempt shuang.he
2014-11-24 14:11 ` [PATCH] drm/i915: Only warn the first time we attempt to mmio whilst suspended Paulo Zanoni
2014-11-24 14:16 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124093828.GL25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.