Re: [PATCH RESEND v4 2/4] DT: pwm: Add binding document for IMG PWM DAC

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1516 bytes --]

On Sat, Nov 22, 2014 at 07:23:30AM +0530, naidu.tellapati@gmail.com wrote:
> From: Naidu Tellapati <Naidu.Tellapati@imgtec.com>
> 
> Add binding document for IMG Pulse Width Modulator (PWM) DAC present on the
> Pistachio SOC. The PWM DAC has four channels.
> 
> Signed-off-by: Naidu Tellapati <Naidu.Tellapati@imgtec.com>
> Signed-off-by: Sai Masarapu <Sai.Masarapu@imgtec.com>
> Reviewed-by: Andrew Bresticker <abrestic@chromium.org>
> ---
> No changes from v3.
> ---
>  Documentation/devicetree/bindings/pwm/img-pwm.txt |   23 +++++++++++++++++++++
>  1 files changed, 23 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pwm/img-pwm.txt
> 
> diff --git a/Documentation/devicetree/bindings/pwm/img-pwm.txt b/Documentation/devicetree/bindings/pwm/img-pwm.txt
> new file mode 100644
> index 0000000..d3828dd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/img-pwm.txt
> @@ -0,0 +1,23 @@
> +*Imagination Technologies PWM DAC driver
> +
> +Required properties:
> +  - compatible: Should be "img,pistachio-pwm"
> +  - reg: Should contain physical base address and length of pwm registers.
> +  - clocks: Must contain an entry for each entry in clock-names.
> +	See ../clock/clock-bindings.txt for details.
> +  - clock-names: input clock names.
> +	Required elements: "pwm" and "sys".

I think it'd be useful to explain at least what the "sys" clock is.
"pwm" I'd assume that it clocks the IP block, but what does "sys" do?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]