From: Andrew Morton <akpm@linux-foundation.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, Davidlohr Bueso <davidlohr@hp.com>,
Rafael Aquini <aquini@redhat.com>,
1vier1@web.de
Subject: Re: [PATCH] ipc,sem block sem_lock on sma->lock during sma initialization
Date: Mon, 24 Nov 2014 12:49:07 -0800 [thread overview]
Message-ID: <20141124124907.a8ba40e5.akpm@linux-foundation.org> (raw)
In-Reply-To: <54722639.1040605@colorfullife.com>
On Sun, 23 Nov 2014 19:23:53 +0100 Manfred Spraul <manfred@colorfullife.com> wrote:
> Subject: [PATCH] ipc/sem.c: Fully initialize sem_array before making it
> visible
>
> ipc_addid() makes a new ipc identifier visible to everyone.
> New objects start as locked, so that the caller can complete
> the initialization after the call.
> Within struct sem_array, at least sma->sem_base and sma->sem_nsems
> are accessed without any locks, therefore this approach doesn't work.
>
> Thus: Move the ipc_addid() to the end of the initialization.
Any thoughts on which kernel version(s) need the patch? I'm still
rather fuzzy on the end-user impact of this bug.
prev parent reply other threads:[~2014-11-24 20:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 19:52 [PATCH] ipc,sem block sem_lock on sma->lock during sma initialization Rik van Riel
2014-11-21 20:07 ` Rafael Aquini
2014-11-21 20:09 ` Andrew Morton
2014-11-21 20:29 ` Rik van Riel
2014-11-21 20:42 ` Andrew Morton
2014-11-21 23:03 ` Rik van Riel
2014-11-22 0:56 ` Davidlohr Bueso
2014-11-22 3:40 ` Rik van Riel
2014-11-22 13:56 ` Manfred Spraul
2014-11-22 15:53 ` Rik van Riel
2014-11-22 19:14 ` Manfred Spraul
2014-11-22 20:14 ` Rik van Riel
2014-11-23 18:23 ` Manfred Spraul
2014-11-23 21:03 ` Rik van Riel
2014-11-23 21:36 ` Davidlohr Bueso
2014-11-24 10:41 ` Rafael Aquini
2014-11-24 20:49 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124124907.a8ba40e5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=1vier1@web.de \
--cc=aquini@redhat.com \
--cc=davidlohr@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.