From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: david.vrabel@citrix.com,
xen-devel <xen-devel@lists.xenproject.org>,
boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen-pciback: drop SR-IOV VFs when PF driver unloads
Date: Mon, 24 Nov 2014 09:51:06 -0500 [thread overview]
Message-ID: <20141124145106.GC3000@laptop.dumpdata.com> (raw)
In-Reply-To: <5472F22B020000780004A28C@mail.emea.novell.com>
On Mon, Nov 24, 2014 at 07:54:03AM +0000, Jan Beulich wrote:
> >>> On 21.11.14 at 23:03, <konrad.wilk@oracle.com> wrote:
> > I rewrote it a bit to be more in the style of pciback:
> >[...]
> > [v2: Removed the switch statement, moved it about]
>
> What you don't mention here is that you also removed the outer
> loop, yet that breaks functionality afaict: There can (and I suppose
> normally will) be multiple VFs needing device_release_driver() called
> when a single PF goes away.
Good point.
>
> Also I'm not really happy for a patch with my S-o-b underneath to
> introduce goto-s without real need.
Will ditch them.
>
> Jan
>
next prev parent reply other threads:[~2014-11-24 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 15:05 [PATCH] xen-pciback: drop SR-IOV VFs when PF driver unloads Jan Beulich
2014-11-21 22:03 ` Konrad Rzeszutek Wilk
2014-11-24 7:54 ` Jan Beulich
2014-11-24 14:51 ` Konrad Rzeszutek Wilk
2014-11-24 14:51 ` Konrad Rzeszutek Wilk [this message]
2014-11-24 7:54 ` Jan Beulich
2014-11-21 22:03 ` Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2014-11-06 15:05 Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124145106.GC3000@laptop.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.