From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>, <stable@vger.kernel.org>
Subject: [for-next][PATCH 2/5] ktest: Fix make_min_config to handle new assign_configs call
Date: Mon, 24 Nov 2014 10:42:53 -0500 [thread overview]
Message-ID: <20141124154331.958171486@goodmis.org> (raw)
In-Reply-To: 20141124154251.345600733@goodmis.org
[-- Attachment #1: 0002-ktest-Fix-make_min_config-to-handle-new-assign_confi.patch --]
[-- Type: text/plain, Size: 1284 bytes --]
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
Commit 6071c22e1755 "ktest: Rewrite the config-bisect to actually work"
fixed the config-bisect to work nicely but in doing so it broke
make_min_config by changing the way assign_configs works.
The assign_configs function now adds the config to the hash even if
it is disabled, but changes the hash value to be that of the
line "# CONFIG_FOO is not set". Unfortunately, the make_min_config
test only checks to see if the config is removed. It now needs to
check if the config is in the hash and not set to be disabled.
Cc: stable@vger.kernel.org # 3.17+
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
tools/testing/ktest/ktest.pl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 60fe020a6e80..89c2257bed98 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -3571,7 +3571,9 @@ sub test_this_config {
undef %configs;
assign_configs \%configs, $output_config;
- return $config if (!defined($configs{$config}));
+ if (!defined($configs{$config}) || $configs{$config} =~ /^#/) {
+ return $config;
+ }
doprint "disabling config $config did not change .config\n";
--
2.1.1
next prev parent reply other threads:[~2014-11-24 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 15:42 [for-next][PATCH 0/5] ktest: Updates for 3.19 Steven Rostedt
2014-11-24 15:42 ` [for-next][PATCH 1/5] ktest: Use make -s kernelrelease Steven Rostedt
2014-11-24 15:42 ` Steven Rostedt [this message]
2014-11-24 15:42 ` [for-next][PATCH 3/5] ktest: Allow tests to undefine default options Steven Rostedt
2014-11-24 15:42 ` [for-next][PATCH 4/5] ktest: Add name to running title Steven Rostedt
2014-11-24 15:42 ` [for-next][PATCH 5/5] ktest: Add back "tail -1" to kernelrelease make Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124154331.958171486@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.