From: Felipe Balbi <balbi@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: <balbi@ti.com>, George Cherian <george.cherian@ti.com>,
<gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled
Date: Mon, 24 Nov 2014 12:20:53 -0600 [thread overview]
Message-ID: <20141124182053.GD25712@saruman> (raw)
In-Reply-To: <54736FBE.6060505@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
On Mon, Nov 24, 2014 at 06:49:50PM +0100, Sebastian Andrzej Siewior wrote:
> On 11/18/2014 10:17 PM, Felipe Balbi wrote:
> > I think the driver is mis-detecting Babble. A babble only occurs when
> > the device side tries to move data without the host asking for anything.
>
> It also occurs if the device moves more than packet_size bytes. Not
> really helping, I know…
hmm, why would the device move more than wMaxPacketSize at a time ?
That's certainly babble :-) We *must* move data in the wire in
<=wMaxPacketSize chunks.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-24 18:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 8:24 [PATCH] usb: musb: core: Disable the Interrupts till BABBLE is fully handled George Cherian
2014-11-14 8:42 ` Sebastian Andrzej Siewior
2014-11-14 9:11 ` George Cherian
2014-11-14 21:02 ` Felipe Balbi
2014-11-18 21:17 ` Felipe Balbi
2014-11-19 0:44 ` Bin Liu
2014-11-19 3:12 ` Felipe Balbi
2014-11-24 17:47 ` Sebastian Andrzej Siewior
2014-11-24 17:49 ` Sebastian Andrzej Siewior
2014-11-24 18:20 ` Felipe Balbi [this message]
2014-11-24 20:39 ` Peter Stuge
2014-11-24 20:56 ` Sebastian Andrzej Siewior
2014-11-25 1:09 ` Felipe Balbi
2014-11-25 8:24 ` Sebastian Andrzej Siewior
2014-11-25 14:49 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124182053.GD25712@saruman \
--to=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=george.cherian@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.