From: "Pali Rohár" <pali.rohar@gmail.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org,
Darren Hart <dvhart@infradead.org>,
Gabriele Mazzotta <gabriele.mzt@gmail.com>,
Alex Hung <alex.hung@canonical.com>
Subject: Re: Reported key not released
Date: Mon, 24 Nov 2014 23:04:48 +0100 [thread overview]
Message-ID: <201411242304.49047@pali> (raw)
In-Reply-To: <20141124215147.GB14361@srcf.ucam.org>
[-- Attachment #1: Type: Text/Plain, Size: 836 bytes --]
On Monday 24 November 2014 22:51:47 Matthew Garrett wrote:
> On Mon, Nov 24, 2014 at 09:58:32PM +0100, Pali Rohár wrote:
> > So kernel should filter i8042 atk key press events which
> > represent HW switch?
>
> Yeah - the firmware is sending an "Update rfkill state"
> message, not a real keypress. If you're already listening for
> those events through a filter then you should just drop them
> once you've done the state update.
Now I wanted to do not use i8042 hook function in dell-laptop.c
which was used only for receiving key event (hw switch) and
propagating it to dell-laptop rfkill device. See my patch:
dell-laptop: Use dell-rbtn instead i8042 filter when possible
But if we really should drop these atk key press, then another
patch for it will be needed.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2014-11-24 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 13:13 Reported key not released Pali Rohár
2014-11-24 20:04 ` Matthew Garrett
2014-11-24 20:58 ` Pali Rohár
2014-11-24 21:51 ` Matthew Garrett
2014-11-24 22:04 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411242304.49047@pali \
--to=pali.rohar@gmail.com \
--cc=alex.hung@canonical.com \
--cc=dvhart@infradead.org \
--cc=gabriele.mzt@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.