All of lore.kernel.org
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/4] clk: rockchip: allow adjusting pll rates on init
Date: Mon, 24 Nov 2014 22:11:15 -0800	[thread overview]
Message-ID: <20141125061115.12298.39795@quantum> (raw)
In-Reply-To: <546EA9E7.6090104@rock-chips.com>

Quoting Kever Yang (2014-11-20 18:56:39)
> Hi Heiko,
> 
> On 11/21/2014 03:38 AM, Heiko Stuebner wrote:
> > It was found that some firmware versions initialized the pll rates using
> > suboptimal parameters to achieve frequencies the actual rate table contained
> > better parameters for.
> >
> > Therefore this series first adds the possibility to create pll-specific flags
> > and then adds a flag to adjust the pll rate on init to the parameters from
> > the rate table.
> >
> > changes since v1:
> > - move population of pll_mux before registering the core pll clock
> >    null pointer exception in the _set_rate callback when called from init
> >
> > Heiko Stuebner (4):
> >    clk: rockchip: add ability to specify pll-specific flags
> >    clk: rockchip: setup pll_mux data earlier
> >    clk: rockchip: add optional sync to pll rate parameters
> >    clk: rockchip: add ROCKCHIP_PLL_SYNC_RATE flag to some plls
> >
> >   drivers/clk/rockchip/clk-pll.c    | 81 +++++++++++++++++++++++++++++++--------
> >   drivers/clk/rockchip/clk-rk3188.c |  8 ++--
> >   drivers/clk/rockchip/clk-rk3288.c | 10 ++---
> >   drivers/clk/rockchip/clk.c        |  3 +-
> >   drivers/clk/rockchip/clk.h        | 13 ++++++-
> >   5 files changed, 88 insertions(+), 27 deletions(-)
> >
> The PLLs may have different usage, so add the pll-specific flag make sense.
> 
> I have test this patch set on both rk3288 evb and rk3288 pinky.
> 
> For this series:
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
> Tested-by: Kever Yang <kever.yang@rock-chips.com>
> 

Looks good to me. I think rk3xxx might be the first user of the .init
callback!

Regards,
Mike

  reply	other threads:[~2014-11-25  6:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 19:38 [PATCH v2 0/4] clk: rockchip: allow adjusting pll rates on init Heiko Stuebner
2014-11-20 19:38 ` [PATCH v2 1/4] clk: rockchip: add ability to specify pll-specific flags Heiko Stuebner
2014-11-20 19:38 ` [PATCH v2 2/4] clk: rockchip: setup pll_mux data earlier Heiko Stuebner
2014-11-20 19:38 ` [PATCH v2 3/4] clk: rockchip: add optional sync to pll rate parameters Heiko Stuebner
2014-11-20 19:38 ` [PATCH v2 4/4] clk: rockchip: add ROCKCHIP_PLL_SYNC_RATE flag to some plls Heiko Stuebner
2014-11-21  2:56 ` [PATCH v2 0/4] clk: rockchip: allow adjusting pll rates on init Kever Yang
2014-11-25  6:11   ` Mike Turquette [this message]
2014-11-25 11:28 ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141125061115.12298.39795@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.