From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH for-xen-4.5] libxl: Allow copying smaller bitmap into a larger one Date: Tue, 25 Nov 2014 09:48:31 +0000 Message-ID: <20141125094831.GC17596@zion.uk.xensource.com> References: <1416518854-5284-1-git-send-email-boris.ostrovsky@oracle.com> <20141124104127.GF30053@zion.uk.xensource.com> <20141124104703.GH30053@zion.uk.xensource.com> <54735343.1020208@oracle.com> <1416908578.7176.10.camel@Abyss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1416908578.7176.10.camel@Abyss> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: Wei Liu , ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org On Tue, Nov 25, 2014 at 10:42:58AM +0100, Dario Faggioli wrote: > On Mon, 2014-11-24 at 10:48 -0500, Boris Ostrovsky wrote: > > On 11/24/2014 05:47 AM, Wei Liu wrote: > > > >> > > >> The partial copy function should explicitly zero-out all remaining bits. > > > > I actually thought that partial copy function should do just that --- > > copy bits that it has and leave others unchanged. The caller, if desires > > so, should have cleared the mask prior to the call. (This is for the > > case when destination is larger than source, of course). > > > Agreed. > > Anyway, AFAIU Wei's proposal, he's saying that this new _copy_partial() > function can be an internal one, i.e., not part of the public API, or > am I wrong, Wei? > > If yes, I agree with that. > You're right. I want to make it internal so that we don't need to worry about the public API for now. > This leaves the question of whether we should change the behavior of the > publicly exposed libxl_bitmap_copy(), which I'm still not sure about, > but I guess, if we keep this internal, we can defer thinking to that to > some other period not in between RCs? > Yes. Wei. > Thanks and Regards, > Dario > > -- > <> (Raistlin Majere) > ----------------------------------------------------------------- > Dario Faggioli, Ph.D, http://about.me/dario.faggioli > Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) >