From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] Revert "drm/i915: Disallow pin ioctl completely for kms drivers" Date: Tue, 25 Nov 2014 13:01:39 +0100 Message-ID: <20141125120139.GA25711@phenom.ffwll.local> References: <1416915776-20730-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 0412F6E75F for ; Tue, 25 Nov 2014 04:01:13 -0800 (PST) Received: by mail-wi0-f174.google.com with SMTP id h11so8906765wiw.1 for ; Tue, 25 Nov 2014 04:01:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <1416915776-20730-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBOb3YgMjUsIDIwMTQgYXQgMTE6NDI6NTZBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFRoaXMgcmV2ZXJ0cyBjb21taXQgYzIxMWE0N2MyYzI4NTYyZjhhM2ZmZjllMDI3YmUx YTNlZDllMTU0YS4KPiAKPiBUaGlzIGNhdXNlcyBhbiB1bndhcnJhbnRlZWQgQVBJIGJyZWFrIGZv ciBleGlzdGluZyBhbmQgYWN0aXZlIHVzZXJzcGFjZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KCkhtLCBTTkEgc3RpbGwgc2VlbXMg dG8gYmUgYWJsZSB0byBjb3BlIHdpdGggdGhpcyBhbmQgSSByZWFsbHkgZG9uJ3Qgc2VlCnRoZSBw b2ludCBvZiBrZWVwaW5nIHRoaXMgaW50ZXJmYWNlIGdvaW5nIGFuZCBwYXRjaGluZyBpdCB1cC4g V2l0aCBHRU0gdGhlCmtlcm5lbCBzaG91bGQgYmUgaW4gY29udHJvbCBvZiBzaGFyZWQgcmVzb3Vy Y2VzLCBsZXR0aW5nIHVzZXJzcGFjZSBpbiB0bwp0aGUgZ2FtZSBqdXN0IGxlYWRzIHRvIHRlYXJz LiBBbmQgd2UgaGF2ZSB0aGVtIG5vdy4gS2VlcGluZyBwaW5uaW5nIGFyb3VuZApqdXN0IGJlY2F1 c2Ugd2UndmUgZm9yZ290dGVuIHRvIHByb3Blcmx5IGRpc2FibGUgaXQgd2FzIG9rIHdpdGggbWUs IGJ1dApmaXhpbmcgaXQgdXAgd2hlbiBpdCBzdGFydHMgdG8gZmFsbCBhcGFydCByZWFsbHkgaXNu J3QuCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCA5 MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hh bmdlZCwgOTAgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4 IDYxNGJjMmJjMTZmZS4uNGExY2E3YWJkN2Y5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j Cj4gQEAgLTQyNTIsNiArNDI1Miw5NiBAQCBpOTE1X2dlbV9vYmplY3RfdW5waW5fZmVuY2Uoc3Ry dWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPiAgfQo+ICAKPiAgaW50Cj4gK2k5MTVfZ2Vt X3Bpbl9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICsJCSAgIHN0 cnVjdCBkcm1fZmlsZSAqZmlsZSkKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9waW4gKmFy Z3MgPSBkYXRhOwo+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iajsKPiArCWludCBy ZXQ7Cj4gKwo+ICsJcmV0ID0gaTkxNV9tdXRleF9sb2NrX2ludGVycnVwdGlibGUoZGV2KTsKPiAr CWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwlvYmogPSB0b19pbnRlbF9ibyhkcm1f Z2VtX29iamVjdF9sb29rdXAoZGV2LCBmaWxlLCBhcmdzLT5oYW5kbGUpKTsKPiArCWlmICgmb2Jq LT5iYXNlID09IE5VTEwpIHsKPiArCQlyZXQgPSAtRU5PRU5UOwo+ICsJCWdvdG8gdW5sb2NrOwo+ ICsJfQo+ICsKPiArCWlmIChvYmotPm1hZHYgIT0gSTkxNV9NQURWX1dJTExORUVEKSB7Cj4gKwkJ RFJNX0RFQlVHKCJBdHRlbXB0aW5nIHRvIHBpbiBhIHB1cmdlYWJsZSBidWZmZXJcbiIpOwo+ICsJ CXJldCA9IC1FRkFVTFQ7Cj4gKwkJZ290byBvdXQ7Cj4gKwl9Cj4gKwo+ICsJaWYgKG9iai0+cGlu X2ZpbHAgIT0gTlVMTCAmJiBvYmotPnBpbl9maWxwICE9IGZpbGUpIHsKPiArCQlEUk1fREVCVUco IkFscmVhZHkgcGlubmVkIGluIGk5MTVfZ2VtX3Bpbl9pb2N0bCgpOiAlZFxuIiwKPiArCQkJICBh cmdzLT5oYW5kbGUpOwo+ICsJCXJldCA9IC1FSU5WQUw7Cj4gKwkJZ290byBvdXQ7Cj4gKwl9Cj4g Kwo+ICsJaWYgKG9iai0+dXNlcl9waW5fY291bnQgPT0gVUxPTkdfTUFYKSB7Cj4gKwkJcmV0ID0g LUVCVVNZOwo+ICsJCWdvdG8gb3V0Owo+ICsJfQo+ICsKPiArCWlmIChvYmotPnVzZXJfcGluX2Nv dW50ID09IDApIHsKPiArCQlyZXQgPSBpOTE1X2dlbV9vYmpfZ2d0dF9waW4ob2JqLCBhcmdzLT5h bGlnbm1lbnQsIFBJTl9NQVBQQUJMRSk7Cj4gKwkJaWYgKHJldCkKPiArCQkJZ290byBvdXQ7Cj4g Kwl9Cj4gKwo+ICsJb2JqLT51c2VyX3Bpbl9jb3VudCsrOwo+ICsJb2JqLT5waW5fZmlscCA9IGZp bGU7Cj4gKwo+ICsJYXJncy0+b2Zmc2V0ID0gaTkxNV9nZW1fb2JqX2dndHRfb2Zmc2V0KG9iaik7 Cj4gK291dDoKPiArCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlKCZvYmotPmJhc2UpOwo+ICt1 bmxvY2s6Cj4gKwltdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiArCXJldHVybiBy ZXQ7Cj4gK30KPiArCj4gK2ludAo+ICtpOTE1X2dlbV91bnBpbl9pb2N0bChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICsJCSAgICAgc3RydWN0IGRybV9maWxlICpmaWxlKQo+ ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3BpbiAqYXJncyA9IGRhdGE7Cj4gKwlzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+ICsJaW50IHJldDsKPiArCj4gKwlyZXQgPSBpOTE1 X211dGV4X2xvY2tfaW50ZXJydXB0aWJsZShkZXYpOwo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4g cmV0Owo+ICsKPiArCW9iaiA9IHRvX2ludGVsX2JvKGRybV9nZW1fb2JqZWN0X2xvb2t1cChkZXYs IGZpbGUsIGFyZ3MtPmhhbmRsZSkpOwo+ICsJaWYgKCZvYmotPmJhc2UgPT0gTlVMTCkgewo+ICsJ CXJldCA9IC1FTk9FTlQ7Cj4gKwkJZ290byB1bmxvY2s7Cj4gKwl9Cj4gKwo+ICsJaWYgKG9iai0+ cGluX2ZpbHAgIT0gZmlsZSkgewo+ICsJCURSTV9ERUJVRygiTm90IHBpbm5lZCBieSBjYWxsZXIg aW4gaTkxNV9nZW1fcGluX2lvY3RsKCk6ICVkXG4iLAo+ICsJCQkgIGFyZ3MtPmhhbmRsZSk7Cj4g KwkJcmV0ID0gLUVJTlZBTDsKPiArCQlnb3RvIG91dDsKPiArCX0KPiArCW9iai0+dXNlcl9waW5f Y291bnQtLTsKPiArCWlmIChvYmotPnVzZXJfcGluX2NvdW50ID09IDApIHsKPiArCQlvYmotPnBp bl9maWxwID0gTlVMTDsKPiArCQlpOTE1X2dlbV9vYmplY3RfZ2d0dF91bnBpbihvYmopOwo+ICsJ fQo+ICsKPiArb3V0Ogo+ICsJZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2UoJm9iai0+YmFzZSk7 Cj4gK3VubG9jazoKPiArCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsJcmV0 dXJuIHJldDsKPiArfQo+ICsKPiAraW50Cj4gIGk5MTVfZ2VtX2J1c3lfaW9jdGwoc3RydWN0IGRy bV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCQkgICAgc3RydWN0IGRybV9maWxlICpmaWxl KQo+ICB7Cj4gLS0gCj4gMi4xLjMKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK