From: Christoph Hellwig <hch@lst.de>
To: Kashyap Desai <kashyap.desai@avagotech.com>
Cc: Hannes Reinecke <hare@suse.de>,
James Bottomley <jbottomley@parallels.com>,
Sumit Saxena <sumit.saxena@avagotech.com>,
linux-scsi@vger.kernel.org, Webb Scales <webbnh@hp.com>,
Don Brace <don.brace@pmcs.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] megaraid_sas: Enable shared host tag map
Date: Tue, 25 Nov 2014 17:34:53 +0100 [thread overview]
Message-ID: <20141125163453.GA2721@lst.de> (raw)
In-Reply-To: <cd290ec39c368c11217bcb4510c9ac71@mail.gmail.com>
On Tue, Nov 25, 2014 at 08:33:28PM +0530, Kashyap Desai wrote:
> Just trying to understand your above comment. I see host template has new
> field called
> "reserved_tags" which is normally used by mid layer to reserved block tag
> pool for driver's internal use.
> What if driver is OK to manage internal pool without any blk tag
> dependency and do not expose actual max can queue of what FW can support.
> For example, in megaraid_sas driver FW expose max_fw_cmd = 1024 and driver
> keep some reserve (let's say 24 commands for internal use) and it just
> expose 1000 command for blk tags. This will work for blk-mq and legacy
> blk driver. Let driver to manage whatever internal reserved it kept for
> and do not add any dependency with blk tag from above layer for those
> reserved pool.
The driver can of coure always just manage its internal tags, but that
means we need to duplicate a tag allocator in every driver. In short
it works ok for now, but I'd rather solve the problem in a single place.
next prev parent reply other threads:[~2014-11-25 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 15:33 [PATCH] megaraid_sas: Enable shared host tag map Hannes Reinecke
2014-11-24 15:35 ` Christoph Hellwig
2014-11-24 15:51 ` Hannes Reinecke
2014-11-24 15:59 ` Kashyap Desai
2014-11-25 14:31 ` Christoph Hellwig
2014-11-25 14:47 ` Hannes Reinecke
2014-11-25 16:30 ` Christoph Hellwig
2014-11-25 15:03 ` Kashyap Desai
2014-11-25 16:34 ` Christoph Hellwig [this message]
2014-11-24 15:52 ` Kashyap Desai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125163453.GA2721@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=don.brace@pmcs.com \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sumit.saxena@avagotech.com \
--cc=webbnh@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.