Re: [PATCH 1/2] tty: serial: 8250: omap: line is unsigned, don't check < 0

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Nov 25, 2014 at 07:08:02PM +0100, Sebastian Andrzej Siewior wrote:
> On 11/12/2014 10:28 AM, Sebastian Andrzej Siewior wrote:
> > Dan Carpenter reported:
> > |drivers/tty/serial/8250/8250_omap.c:1025 omap8250_probe()
> > |warn: unsigned 'up.port.line' is never less than zero.
> > |1025          if (up.port.line < 0) {
> > 
> > I (wrongly) assumed that line is an int and compiler didn't complain nor
> > did sparse. Since of_alias_get_id() and pdev->id can get negative I
> > check for the error via ret variable.
> > 
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> 
> Greg, did those two slip through or do you wait for something until you
> apply them?

I'm still working on catching up with my tty/serial patches, this is in
the queue...