From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtVyc-0000Qh-MG for qemu-devel@nongnu.org; Wed, 26 Nov 2014 01:21:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtVyW-0006wb-Gs for qemu-devel@nongnu.org; Wed, 26 Nov 2014 01:21:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtVyW-0006wW-81 for qemu-devel@nongnu.org; Wed, 26 Nov 2014 01:21:16 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAQ6LEqq017721 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 26 Nov 2014 01:21:14 -0500 Date: Wed, 26 Nov 2014 14:21:21 +0800 From: Amos Kong Message-ID: <20141126062121.GD26731@air.redhat.com> References: <1416899934-13952-1-git-send-email-kraxel@redhat.com> <87ioi3puut.fsf@blackfin.pond.sub.org> <20141125083700.GA26731@air.redhat.com> <87fvd7lcee.fsf@blackfin.pond.sub.org> <5474AFCE.9080007@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wULyF7TL5taEdwHz" Content-Disposition: inline In-Reply-To: <5474AFCE.9080007@redhat.com> Subject: Re: [Qemu-devel] [PATCH] input: move input-send-event into experimental namespace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Markus Armbruster , Luiz Capitulino --wULyF7TL5taEdwHz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 25, 2014 at 09:35:26AM -0700, Eric Blake wrote: > On 11/25/2014 04:58 AM, Markus Armbruster wrote: > > Amos Kong writes: > >=20 > >> On Tue, Nov 25, 2014 at 09:06:34AM +0100, Markus Armbruster wrote: > >>> Gerd Hoffmann writes: > >>> > >>>> Ongoing discussions on how we are going to specify the console, > >>>> so tag the command as experiemntal so we can refine things in > >>>> the 2.3 development cycle. > >>>> > >>>> Signed-off-by: Gerd Hoffmann > >>>> --- > >>>> qmp-commands.hx | 12 ++++++------ > >>> > >>> Don't you need to patch qapi-schema.json, too? > >> > >> Not necessary in function level. > >=20 > > s/need to/want to/? >=20 > Yes, if you are going to mark the HMP command experimental, please also > mark the QMP command as experimental. Gerd's patch wasn't make hmp command experimental, but QMP. Inputted command will be compared with .name field in qmp-commands.hx, not qapi-schema.json. The command name in qapi-schema.json only effects the function name. But it's good to also update qapi-schema.json. --=20 Amos. --wULyF7TL5taEdwHz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUdXFhAAoJELxSv6I5vP9jchAP/27Onjfqphqz0gyqudAOZFbu qgo2U5Dr/5m4N9Y19W9ChPXQfTvANM4Cyg6exNFwS6DLDODHqYyaEb5w/x3mGfo+ fLxwfqHGk16+cAL9OVY4Gy7VKhW/va5x3iHdVhjIsCTu683QBoUg22/6EMNAZiev yG2B1ZPyNQOpdtkmYFe1G/HM/UVF5f3VzygnssOo1TyoxfJSuSYzD7Ni6Wc66q1A 1+MF19F8HJtBN0S3s39ayDQeekwoX0yhHoBqYWQHg60JCe2WHf1lB4/1KyUBCbTt 5DpsesQzGt4lFTZj3th4Dh8s5o/rZi0oJ5o2FFTjhPiA2q0THDnGt/S7tHst1Lrf voLqF/7JXIgCsky75emvz1KrKAzdlAnDkG6yfZGJKKOZRw+FYPxr5fUL3OtLArB1 RNwIVKBasYiMFFi1ruXE2kTJx9IUioBlcg1GEenoCSvHcOVO6R0/HLvARc3qqG+6 ZaXRAmWflgUaW/nZx+263PZtqTAMX+2JppxiRvt8bGsoOxHm5PD8PXqYIXGSldL/ Lj6ZeUsV73h3YJRuM3DP5vo9+jX5zmWmrC7Sen8IaIaqE4m41CIR3h97kT6soRe1 4oo8f6ZuioFN4PAU8clTpZljPJxFM3gqdzvXp5FwQcmw+wO3lTIT+PNPtADA6vQG UKF6QcwywTpOkDNXWX/+ =E2KH -----END PGP SIGNATURE----- --wULyF7TL5taEdwHz--