From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Paolo Bonzini <pbonzini@redhat.com>, nick <xerofoify@gmail.com>,
gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Another Obsolete Fix me in trace.h?
Date: Wed, 26 Nov 2014 15:49:34 +0100 [thread overview]
Message-ID: <20141126144933.GA5630@potion.brq.redhat.com> (raw)
In-Reply-To: <20141126091543.52dc5bfe@gandalf.local.home>
2014-11-26 09:15-0500, Steven Rostedt:
> On Wed, 26 Nov 2014 13:40:26 +0100
> Radim Krčmář <rkrcmar@redhat.com> wrote:
> > The kernel part is trivial.
> > Most of the code is going to be in tools/lib/traceevent/event-parse.c.
> >
> > I wasn't sure whether to
> > 1) define new 'enum print_arg_type' for our function and do exactly what
> > other __print* did
> > 2) extend existing PRINT_FUNC with variable arguments and register it as
> > a "global" event handler
> >
> > as (2) makes more sense to me, but we already had it when some __print*
> > was implemented ... (and I didn't want to dig too deep into the project)
>
> Add a new hardcoded instance. The PRINT_FUNC is for plugins that have a
> unique function for the events they handle. Notice that event-parse
> does not define any func handlers. If this is to be generic, then lets
> make it specified as a new enum.
Ok, thanks.
(It just seemed weird that we have an infrastructure that could allow a
"generic plugin" to cover this functionality.)
next prev parent reply other threads:[~2014-11-26 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5472B5B5.5090201@gmail.com>
2014-11-24 10:12 ` Another Obsolete Fix me in trace.h? Paolo Bonzini
2014-11-24 10:40 ` Jan Kiszka
2014-11-24 21:00 ` Radim Krčmář
2014-11-24 21:19 ` Steven Rostedt
2014-11-24 21:49 ` Radim Krčmář
2014-11-26 12:40 ` Radim Krčmář
2014-11-26 14:15 ` Steven Rostedt
2014-11-26 14:49 ` Radim Krčmář [this message]
2014-11-26 15:23 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126144933.GA5630@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.