All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 08/10] netfilter: ipset: Introduce RCU in all set types instead of rwlock per set
Date: Wed, 26 Nov 2014 18:18:08 +0100	[thread overview]
Message-ID: <20141126171808.GC3585@salvia> (raw)
In-Reply-To: <alpine.DEB.2.10.1411261659030.9422@blackhole.kfki.hu>

On Wed, Nov 26, 2014 at 05:01:39PM +0100, Jozsef Kadlecsik wrote:
> On Wed, 26 Nov 2014, Florian Westphal wrote:
> > 
> > I don't see why you'd need a special function otherwise, unless you
> > want some explicit documentation as to where you're changing/updating
> > content of structures protected by rcu.  But, in those sections you
> > already need to hold some type of lock, so I don't think its needed.
> 
> Hm, you are both right - I clean up this part as it's totally unnecessary, 
> these are not pointers, even indirectly.

Thanks.

Please, I'd appreciate if you send smaller batches for nf-next for
easier review. So instead of large batches, more frequent pull
requests if possible.

  reply	other threads:[~2014-11-26 17:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 20:46 [PATCH 00/10] ipset patches for nf-next Jozsef Kadlecsik
2014-11-24 20:46 ` [PATCH 01/10] netfilter: ipset: Support updating extensions when the set is full Jozsef Kadlecsik
2014-11-24 20:46 ` [PATCH 02/10] netfilter: ipset: Alignment problem between 64bit kernel 32bit userspace Jozsef Kadlecsik
2014-11-24 20:46 ` [PATCH 03/10] netfilter: ipset: Indicate when /0 networks are supported Jozsef Kadlecsik
2014-11-24 20:46 ` [PATCH 04/10] netfilter: ipset: Simplify cidr handling for hash:*net* types Jozsef Kadlecsik
2014-11-24 20:46 ` [PATCH 05/10] netfilter: ipset: Allocate the proper size of memory when /0 networks are supported Jozsef Kadlecsik
2014-11-24 20:46 ` [PATCH 06/10] netfilter: ipset: Explicitly add padding elements to hash:net,net and hash:net,port,net Jozsef Kadlecsik
2014-11-24 20:46 ` [PATCH 07/10] netfilter: ipset: Remove rbtree from hash:net,iface in order to run under RCU Jozsef Kadlecsik
2014-11-24 20:46 ` [PATCH 08/10] netfilter: ipset: Introduce RCU in all set types instead of rwlock per set Jozsef Kadlecsik
2014-11-26 13:14   ` Pablo Neira Ayuso
2014-11-26 14:58     ` Jozsef Kadlecsik
2014-11-26 15:41       ` Florian Westphal
2014-11-26 16:01         ` Jozsef Kadlecsik
2014-11-26 17:18           ` Pablo Neira Ayuso [this message]
2014-11-27  8:23             ` Jozsef Kadlecsik
2014-11-24 20:46 ` [PATCH 09/10] netfilter: ipset: styles warned by checkpatch.pl fixed Jozsef Kadlecsik
2014-11-24 20:46 ` [PATCH 10/10] netfilter: ipset: Fix parallel resizing and listing of the same set Jozsef Kadlecsik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141126171808.GC3585@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.