From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Øystein Walle" <oystwa@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/2] pre-commit hook updates
Date: Wed, 26 Nov 2014 13:56:11 -0500 [thread overview]
Message-ID: <20141126185610.GA1734@peff.net> (raw)
In-Reply-To: <xmqqfvd5res5.fsf@gitster.dls.corp.google.com>
On Wed, Nov 26, 2014 at 10:35:22AM -0800, Junio C Hamano wrote:
> I _think_ "give only info that is necessary" is cleaner as an
> interface in theory, but have two niggles myself:
>
> 1. the hooks must do the "argument parsing" loop (you already
> mentioned this);
>
> 2. the hooks cannot tell if the lack of "amending" argument is
> because the version of Git predates that "amending" hint
> support, or because the user action is a straight "commit" not
> an "commit --amend".
>
> In any case, I do not have strong preference myself.
That agrees with my thinking exactly.
At this point since both of us seem on the fence, I am happy to let
Øystein, as the person who is actually writing the patch, decide.
-Peff
prev parent reply other threads:[~2014-11-26 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 22:51 [PATCH 0/2] pre-commit hook updates Øystein Walle
[not found] ` <cover.1416955873.git.oystwa@gmail.com>
2014-11-25 22:51 ` [PATCH 1/2] t7503: use write_script to generate hook scripts Øystein Walle
2014-11-26 1:25 ` Eric Sunshine
2014-11-26 4:51 ` Jeff King
2014-11-26 18:12 ` Junio C Hamano
2014-11-26 19:03 ` Jeff King
2014-11-26 20:07 ` Junio C Hamano
2014-11-25 22:51 ` [PATCH 2/2] commit: inform pre-commit that --amend was used Øystein Walle
2014-11-26 1:36 ` Eric Sunshine
2014-11-26 1:32 ` [PATCH 0/2] pre-commit hook updates Eric Sunshine
2014-11-26 4:52 ` Jeff King
2014-11-26 18:35 ` Junio C Hamano
2014-11-26 18:56 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126185610.GA1734@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=oystwa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.