From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [hch-scsi-queue:drivers-for-3.19 174/180] drivers/scsi/wd719x.c:247:2: error: implicit declaration of function 'dma_cache_sync' Date: Wed, 26 Nov 2014 20:13:09 +0100 Message-ID: <20141126191309.GA32112@lst.de> References: <201411252333.lLEJOiQu%fengguang.wu@intel.com> <20141126102843.GB23189@lst.de> <201411261832.48201.linux@rainbow-software.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <201411261832.48201.linux@rainbow-software.org> Sender: sparclinux-owner@vger.kernel.org To: Ondrej Zary Cc: Christoph Hellwig , kbuild test robot , kbuild-all@01.org, linux-scsi@vger.kernel.org, sparclinux@vger.kernel.org, Arnd Bergmann List-Id: linux-scsi@vger.kernel.org On Wed, Nov 26, 2014 at 06:32:48PM +0100, Ondrej Zary wrote: > wd819x should probably depend on VIRT_TO_BUS? But that means it will not work > on sparc. Is there a way to make it work? I have a sparc machine but haven't > tested it. The explanation from Arnd in the other thread makes more sense - dma_cache_sync only is for non-coherent allocations so we should be able to remove it entirely. Can you prepare and test a patch to just remove it for me? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 26 Nov 2014 19:13:09 +0000 Subject: Re: [hch-scsi-queue:drivers-for-3.19 174/180] drivers/scsi/wd719x.c:247:2: error: implicit declarati Message-Id: <20141126191309.GA32112@lst.de> List-Id: References: <201411252333.lLEJOiQu%fengguang.wu@intel.com> <20141126102843.GB23189@lst.de> <201411261832.48201.linux@rainbow-software.org> In-Reply-To: <201411261832.48201.linux@rainbow-software.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ondrej Zary Cc: Christoph Hellwig , kbuild test robot , kbuild-all@01.org, linux-scsi@vger.kernel.org, sparclinux@vger.kernel.org, Arnd Bergmann On Wed, Nov 26, 2014 at 06:32:48PM +0100, Ondrej Zary wrote: > wd819x should probably depend on VIRT_TO_BUS? But that means it will not work > on sparc. Is there a way to make it work? I have a sparc machine but haven't > tested it. The explanation from Arnd in the other thread makes more sense - dma_cache_sync only is for non-coherent allocations so we should be able to remove it entirely. Can you prepare and test a patch to just remove it for me?