From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling Date: Wed, 26 Nov 2014 16:09:40 -0500 Message-ID: <20141126210940.GA15328@laptop.dumpdata.com> References: <1417014580-27611-1-git-send-email-andrew.cooper3@citrix.com> <5475F3DF.2070907@zheng.li> <0CD34053-C7C1-423B-9D00-E455B7099968@citrix.com> <20141126184130.GB13384@laptop.dumpdata.com> <370F66B9-E96D-4BE2-9E08-132CCBD28E42@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <370F66B9-E96D-4BE2-9E08-132CCBD28E42@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dave Scott Cc: Zheng Li , Wei Liu , Ian Campbell , Andrew Cooper , Xen-devel , "Zheng Li (3P)" , Ian Jackson List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBOb3YgMjYsIDIwMTQgYXQgMDg6NDQ6NDFQTSArMDAwMCwgRGF2ZSBTY290dCB3cm90 ZToKPiAKPiA+IE9uIDI2IE5vdiAyMDE0LCBhdCAxODo0MSwgS29ucmFkIFJ6ZXN6dXRlayBXaWxr IDxrb25yYWQud2lsa0BvcmFjbGUuY29tPiB3cm90ZToKPiA+IAo+ID4gT24gV2VkLCBOb3YgMjYs IDIwMTQgYXQgMDY6MjQ6MTFQTSArMDAwMCwgRGF2ZSBTY290dCB3cm90ZToKPiA+PiAKPiA+Pj4g T24gMjYgTm92IDIwMTQsIGF0IDE1OjM4LCBaaGVuZyBMaSA8ZGV2QHpoZW5nLmxpPiB3cm90ZToK PiA+Pj4gCj4gPj4+IE9uIDI2LzExLzIwMTQgMTU6MDksIEFuZHJldyBDb29wZXIgd3JvdGU6Cj4g Pj4+PiBUaGlzIG1ha2VzIGZpZWxkcyAwIGFuZCAxIHRydWUgbW9yZSBvZnRlbiB0aGFuIHRoZXkg c2hvdWxkIGJlLCByZXN1bHRpbmcKPiA+Pj4+IHByb2JsZW1zIHdoZW4gaGFuZGxpbmcgZXZlbnRz Lgo+ID4+PiAKPiA+Pj4gSW5kZWVkLCBsb29rcyBsaWtlIGEgbWlzdGFrZSBJIG1hZGUgd2hlbiBy ZXdyaXRpbmcgdGhlIGxvZ2ljIHRlcm1zIGxhdGVseS4gVGhlIHJlc3VsdCBpcyBQT0xMVVAgb3Ig UE9MTEVSUiBldmVudHMgYmVpbmcgcmV0dXJuZWQgaW4gbW9yZSBjYXRlZ29yaWVzIHRoYW4gd2Un ZCBpbnRlcmVzdC4gVGhhbmtzIGZvciBmaXhpbmcgdGhpcyEKPiA+Pj4gCj4gPj4+IEFja2VkLWJ5 OiBaaGVuZyBMaSA8ZGV2QHpoZW5nLmxpPgo+ID4+IAo+ID4+IFRoaXMgYWxzbyBsb29rcyBmaW5l IHRvIG1lCj4gPj4gCj4gPj4gQWNrZWQtYnk6IERhdmlkIFNjb3R0IDxkYXZlLnNjb3R0QGNpdHJp eC5jb20+Cj4gPiAKPiA+IFdvdWxkIGl0IGJlIHBvc3NpYmxlIHRvIGdldCBhbiBSZXZpZXdlZC1i eSBwbGVhc2U/Cj4gCj4gSeKAmWxsIGNlcnRhaW5seSBvZmZlcgo+IAo+IFJldmlld2VkLWJ5OiBE YXZpZCBTY290dCA8ZGF2ZS5zY290dEBjaXRyaXguY29tPgoKT0ssIFJlbGVhc2UtQWNrZWQtYnk6 IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4KClRoYW5rIHlv dS4KPiAKPiBDaGVlcnMsCj4gRGF2ZQo+IAo+ID4gCj4gPiBUaGFuayB5b3UuCj4gPj4gCj4gPj4g Q2hlZXJzLAo+ID4+IERhdmUKPiA+PiAKPiA+Pj4gCj4gPj4+IAo+ID4+PiBDaGVlcnMsCj4gPj4+ IFpoZW5nCj4gPj4+IAo+ID4+PiAKPiA+Pj4+IC0tLQo+ID4+Pj4gCj4gPj4+PiBUaGlzIHdhcyBk aXNjb3ZlcmVkIHdpdGggWGVuU2VydmVycyBpbnRlcm5hbCBDb3Zlcml0eSBpbnN0YW5jZS4gIEkg aGF2ZSB5ZXQgdG8KPiA+Pj4+IHdvcmsgb3V0IHdoeSB0aGUgaXNzdWUgaXMgbm90IGlkZW50aWZp ZWQgYnkgdGhlIHVwc3RyZWFtIGNvdmVyaXR5IHNjYW5uaW5nLgo+ID4+Pj4gCj4gPj4+PiBLb25y YWQ6IFRoaXMgaXMgYSBidWcgaW4gdGhlIGRlZmF1bHQgZXZlbnQgaGFuZGxpbmcgdXNlZCBieSBv eGVuc3RvcmVkIGluIDQuNSwKPiA+Pj4+IGFzIHRoZSBkZWZhdWx0IHN3aXRjaGVkIGZyb20gc2Vs ZWN0KCkgdG8gcG9sbCgpIGluIHRoZSA0LjUgdGltZWZyYW1lLiAgSXQKPiA+Pj4+IHdvdWxkIGFw cGVhciB0aGF0IHRoZSBuZWdhdGl2ZSBzaWRlIGVmZmVjdHMgYXJlIGxpbWl0ZWQgdG8ganVzdCBs b2dzcGFtIGFib3V0Cj4gPj4+PiBjZXJ0YWluIGNsaWVudHMgYXR0ZW1wdGluZyBpbnZhbGlkIGFj dGlvbnMsIGJ1dCBJIGNhbid0IHJ1bGUgb3V0IGFueXRoaW5nIG1vcmUKPiA+Pj4+IHByb2JsZW1h dGljLgo+ID4+Pj4gLS0tCj4gPj4+PiB0b29scy9vY2FtbC94ZW5zdG9yZWQvc2VsZWN0X3N0dWJz LmMgfCAgICA0ICsrLS0KPiA+Pj4+IDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCj4gPj4+PiAKPiA+Pj4+IGRpZmYgLS1naXQgYS90b29scy9vY2FtbC94ZW5z dG9yZWQvc2VsZWN0X3N0dWJzLmMgYi90b29scy9vY2FtbC94ZW5zdG9yZWQvc2VsZWN0X3N0dWJz LmMKPiA+Pj4+IGluZGV4IDRhOGVkYjUuLmFmNzJiODQgMTAwNjQ0Cj4gPj4+PiAtLS0gYS90b29s cy9vY2FtbC94ZW5zdG9yZWQvc2VsZWN0X3N0dWJzLmMKPiA+Pj4+ICsrKyBiL3Rvb2xzL29jYW1s L3hlbnN0b3JlZC9zZWxlY3Rfc3R1YnMuYwo+ID4+Pj4gQEAgLTU2LDggKzU2LDggQEAgQ0FNTHBy aW0gdmFsdWUgc3R1Yl9zZWxlY3Rfb25fcG9sbCh2YWx1ZSBmZF9ldmVudHMsIHZhbHVlIHRpbWVv KSB7Cj4gPj4+PiAJCQlldmVudHMgPSBGaWVsZChGaWVsZChmZF9ldmVudHMsIGkpLCAxKTsKPiA+ Pj4+IAo+ID4+Pj4gCQkJaWYgKGNfZmRzW2ldLnJldmVudHMgJiBQT0xMTlZBTCkgdW5peF9lcnJv cihFQkFERiwgInNlbGVjdCIsIE5vdGhpbmcpOwo+ID4+Pj4gLQkJCUZpZWxkKGV2ZW50cywgMCkg PSBWYWxfYm9vbChjX2Zkc1tpXS5ldmVudHMgfCBQT0xMSU4gICYmIGNfZmRzW2ldLnJldmVudHMg JiAoUE9MTElOIHxQT0xMSFVQfFBPTExFUlIpKTsKPiA+Pj4+IC0JCQlGaWVsZChldmVudHMsIDEp ID0gVmFsX2Jvb2woY19mZHNbaV0uZXZlbnRzIHwgUE9MTE9VVCAmJiBjX2Zkc1tpXS5yZXZlbnRz ICYgKFBPTExPVVR8UE9MTEhVUHxQT0xMRVJSKSk7Cj4gPj4+PiArCQkJRmllbGQoZXZlbnRzLCAw KSA9IFZhbF9ib29sKGNfZmRzW2ldLmV2ZW50cyAmIFBPTExJTiAgJiYgY19mZHNbaV0ucmV2ZW50 cyAmIChQT0xMSU4gfFBPTExIVVB8UE9MTEVSUikpOwo+ID4+Pj4gKwkJCUZpZWxkKGV2ZW50cywg MSkgPSBWYWxfYm9vbChjX2Zkc1tpXS5ldmVudHMgJiBQT0xMT1VUICYmIGNfZmRzW2ldLnJldmVu dHMgJiAoUE9MTE9VVHxQT0xMSFVQfFBPTExFUlIpKTsKPiA+Pj4+IAkJCUZpZWxkKGV2ZW50cywg MikgPSBWYWxfYm9vbChjX2Zkc1tpXS5yZXZlbnRzICYgUE9MTFBSSSk7Cj4gPj4+PiAKPiA+Pj4+ IAkJfQo+ID4+Pj4gCj4gPj4gCj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gPiBYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Cj4gPiBYZW4tZGV2 ZWxAbGlzdHMueGVuLm9yZwo+ID4gaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCj4gCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwg bWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3Jn L3hlbi1kZXZlbAo=