From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mariusz Gorski <marius.gorski@gmail.com>
Cc: Willy Tarreau <w@1wt.eu>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state
Date: Wed, 26 Nov 2014 13:58:01 -0800 [thread overview]
Message-ID: <20141126215801.GA32756@kroah.com> (raw)
In-Reply-To: <1416429531-11088-5-git-send-email-marius.gorski@gmail.com>
On Wed, Nov 19, 2014 at 09:38:46PM +0100, Mariusz Gorski wrote:
> Avoid magic number and use a comparison with a defined value instead
> that checks whether module param has been set by the user to some
> value at loading time.
>
> Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
> Acked-by: Willy Tarreau <w@1wt.eu>
> ---
> v2: Don't introduce new macros for param value check
>
> drivers/staging/panel/panel.c | 86 +++++++++++++++++++++----------------------
> 1 file changed, 43 insertions(+), 43 deletions(-)
Ugh, I messed up here, and applied the first series, which was acked.
Mariusz, can you resend the patches that I didn't apply, I can't seem to
get the rest of these to work properly.
thanks,
greg k-h
next prev parent reply other threads:[~2014-11-26 21:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 20:38 [PATCH v2 0/9] staging: panel: Refactor panel initialization Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 1/9] staging: panel: Set default parport module param value Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 2/9] staging: panel: Call init function directly Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 3/9] staging: panel: Remove magic numbers Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 4/9] staging: panel: Use defined value or checking module params state Mariusz Gorski
2014-11-19 21:10 ` Willy Tarreau
2014-11-26 21:58 ` Greg Kroah-Hartman [this message]
2014-11-27 13:26 ` Mariusz Gorski
2014-11-27 15:24 ` Greg Kroah-Hartman
2014-11-27 15:57 ` Greg Kroah-Hartman
2014-11-27 16:14 ` Willy Tarreau
2014-11-27 16:28 ` Greg Kroah-Hartman
2014-11-27 19:50 ` Mariusz Gorski
2014-11-27 21:05 ` Willy Tarreau
2014-11-27 21:10 ` Fabio Estevam
2014-11-28 20:32 ` Greg Kroah-Hartman
2014-11-28 20:57 ` Mariusz Gorski
2014-11-28 22:14 ` Greg Kroah-Hartman
2014-11-19 20:38 ` [PATCH v2 5/9] staging: panel: Start making module params read-only Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 6/9] staging: panel: Make two more " Mariusz Gorski
2014-11-19 21:11 ` Willy Tarreau
2014-11-19 20:38 ` [PATCH v2 7/9] staging: panel: Refactor LCD init code Mariusz Gorski
2014-11-19 21:11 ` Willy Tarreau
2014-11-19 20:38 ` [PATCH v2 8/9] staging: panel: Remove more magic number comparison Mariusz Gorski
2014-11-19 21:11 ` Willy Tarreau
2014-11-19 20:38 ` [PATCH v2 9/9] staging: panel: Move LCD-related state into struct lcd Mariusz Gorski
2014-11-19 21:12 ` [PATCH v2 0/9] staging: panel: Refactor panel initialization Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126215801.GA32756@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.gorski@gmail.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.